Skip to content

Commit 86148df

Browse files
Merge pull request #1308 from adopted-ember-addons/fix/stabilise-catalog-contacts
chore(tests/dummy/app/controllers/catalog): stabilises catalog contacts.
2 parents 6ab201b + 5fdafc0 commit 86148df

File tree

1 file changed

+67
-27
lines changed

1 file changed

+67
-27
lines changed

tests/dummy/app/controllers/catalog.js

Lines changed: 67 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import { A } from '@ember/array';
33
import { action } from '@ember/object';
44
import { later, cancel } from '@ember/runloop';
55
import { inject as service } from '@ember/service';
6-
import { faker } from '@faker-js/faker';
76
import { tracked } from '@glimmer/tracking';
87
import { buildGridModel } from '../utils/grid-list';
98
import { isTesting } from '@embroider/macros';
@@ -371,20 +370,8 @@ export default class CatalogController extends Controller {
371370
}
372371

373372
// Contact Chips
374-
contactChipsNumOfContacts = 10;
375373
get contactChipsContacts() {
376-
let contacts = [];
377-
let numOfContacts = this.contactChipsNumOfContacts;
378-
379-
for (let i = 0; i < numOfContacts; i++) {
380-
contacts.push({
381-
name: faker.person.fullName(),
382-
email: faker.internet.email(),
383-
image: faker.image.avatar(),
384-
});
385-
}
386-
387-
return contacts;
374+
return defaultContacts();
388375
}
389376
get contactChipsSelectedContacts() {
390377
return this.contactChipsContacts.filter((c, index) => {
@@ -420,20 +407,8 @@ export default class CatalogController extends Controller {
420407
}
421408

422409
// List
423-
listNumOfRows = 3;
424410
get listData() {
425-
let contacts = [];
426-
let numOfRows = this.listNumOfRows;
427-
428-
for (let i = 0; i < numOfRows; i++) {
429-
contacts.push({
430-
name: faker.person.fullName(),
431-
email: faker.internet.email(),
432-
img: faker.image.dataUri(),
433-
});
434-
}
435-
436-
return contacts;
411+
return defaultContacts().slice(0, 3);
437412
}
438413
listPhoneNumbers = Object.freeze([
439414
{
@@ -606,3 +581,68 @@ export default class CatalogController extends Controller {
606581
// TODO we might be able to clean this up later when we remove use of `later()` in the codebase
607582
toastDuration = false;
608583
}
584+
585+
function defaultContacts() {
586+
return [
587+
{
588+
name: 'Marc Upton III',
589+
590+
image: 'https://avatars.githubusercontent.com/u/34758178',
591+
img: 'data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZlcnNpb249IjEuMSIgYmFzZVByb2ZpbGU9ImZ1bGwiIHdpZHRoPSIyOTUiIGhlaWdodD0iMTYzMyI+PHJlY3Qgd2lkdGg9IjEwMCUiIGhlaWdodD0iMTAwJSIgZmlsbD0iIzdjMGVkYyIvPjx0ZXh0IHg9IjE0Ny41IiB5PSI4MTYuNSIgZm9udC1zaXplPSIyMCIgYWxpZ25tZW50LWJhc2VsaW5lPSJtaWRkbGUiIHRleHQtYW5jaG9yPSJtaWRkbGUiIGZpbGw9IndoaXRlIj4yOTV4MTYzMzwvdGV4dD48L3N2Zz4=',
592+
},
593+
{
594+
name: 'Krystal Marks',
595+
596+
image: 'https://avatars.githubusercontent.com/u/74532735',
597+
img: 'data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZlcnNpb249IjEuMSIgYmFzZVByb2ZpbGU9ImZ1bGwiIHdpZHRoPSI3MDUiIGhlaWdodD0iMzAwMCI+PHJlY3Qgd2lkdGg9IjEwMCUiIGhlaWdodD0iMTAwJSIgZmlsbD0iI2JhZWMyNSIvPjx0ZXh0IHg9IjM1Mi41IiB5PSIxNTAwIiBmb250LXNpemU9IjIwIiBhbGlnbm1lbnQtYmFzZWxpbmU9Im1pZGRsZSIgdGV4dC1hbmNob3I9Im1pZGRsZSIgZmlsbD0id2hpdGUiPjcwNXgzMDAwPC90ZXh0Pjwvc3ZnPg==',
598+
},
599+
{
600+
name: 'Dr. Charlene Pacocha',
601+
602+
image: 'https://avatars.githubusercontent.com/u/20957179',
603+
img: 'data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZlcnNpb249IjEuMSIgYmFzZVByb2ZpbGU9ImZ1bGwiIHdpZHRoPSIxODgzIiBoZWlnaHQ9IjMyMzQiPjxyZWN0IHdpZHRoPSIxMDAlIiBoZWlnaHQ9IjEwMCUiIGZpbGw9IiMzZDJhYmQiLz48dGV4dCB4PSI5NDEuNSIgeT0iMTYxNyIgZm9udC1zaXplPSIyMCIgYWxpZ25tZW50LWJhc2VsaW5lPSJtaWRkbGUiIHRleHQtYW5jaG9yPSJtaWRkbGUiIGZpbGw9IndoaXRlIj4xODgzeDMyMzQ8L3RleHQ+PC9zdmc+',
604+
},
605+
{
606+
name: 'Mrs. Ginger Mohr DDS',
607+
608+
image: 'https://avatars.githubusercontent.com/u/11685726',
609+
img: 'data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZlcnNpb249IjEuMSIgYmFzZVByb2ZpbGU9ImZ1bGwiIHdpZHRoPSIxODcxIiBoZWlnaHQ9IjUxNyI+PHJlY3Qgd2lkdGg9IjEwMCUiIGhlaWdodD0iMTAwJSIgZmlsbD0iI2VhODY1YSIvPjx0ZXh0IHg9IjkzNS41IiB5PSIyNTguNSIgZm9udC1zaXplPSIyMCIgYWxpZ25tZW50LWJhc2VsaW5lPSJtaWRkbGUiIHRleHQtYW5jaG9yPSJtaWRkbGUiIGZpbGw9IndoaXRlIj4xODcxeDUxNzwvdGV4dD48L3N2Zz4=',
610+
},
611+
{
612+
name: 'Dr. Blake Macejkovic',
613+
614+
image: 'https://avatars.githubusercontent.com/u/84034715',
615+
img: 'data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZlcnNpb249IjEuMSIgYmFzZVByb2ZpbGU9ImZ1bGwiIHdpZHRoPSIyMDI3IiBoZWlnaHQ9IjI3MzAiPjxyZWN0IHdpZHRoPSIxMDAlIiBoZWlnaHQ9IjEwMCUiIGZpbGw9IiMyODlhNGEiLz48dGV4dCB4PSIxMDEzLjUiIHk9IjEzNjUiIGZvbnQtc2l6ZT0iMjAiIGFsaWdubWVudC1iYXNlbGluZT0ibWlkZGxlIiB0ZXh0LWFuY2hvcj0ibWlkZGxlIiBmaWxsPSJ3aGl0ZSI+MjAyN3gyNzMwPC90ZXh0Pjwvc3ZnPg==',
616+
},
617+
{
618+
name: 'Caleb Tillman',
619+
620+
image: 'https://avatars.githubusercontent.com/u/95453771',
621+
img: 'data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZlcnNpb249IjEuMSIgYmFzZVByb2ZpbGU9ImZ1bGwiIHdpZHRoPSIyODk1IiBoZWlnaHQ9IjM4ODMiPjxyZWN0IHdpZHRoPSIxMDAlIiBoZWlnaHQ9IjEwMCUiIGZpbGw9IiNhYjI5NGMiLz48dGV4dCB4PSIxNDQ3LjUiIHk9IjE5NDEuNSIgZm9udC1zaXplPSIyMCIgYWxpZ25tZW50LWJhc2VsaW5lPSJtaWRkbGUiIHRleHQtYW5jaG9yPSJtaWRkbGUiIGZpbGw9IndoaXRlIj4yODk1eDM4ODM8L3RleHQ+PC9zdmc+',
622+
},
623+
{
624+
name: 'Yolanda Lind',
625+
626+
image: 'https://avatars.githubusercontent.com/u/28673259',
627+
img: 'data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZlcnNpb249IjEuMSIgYmFzZVByb2ZpbGU9ImZ1bGwiIHdpZHRoPSIzMzA2IiBoZWlnaHQ9IjE5NTgiPjxyZWN0IHdpZHRoPSIxMDAlIiBoZWlnaHQ9IjEwMCUiIGZpbGw9IiM5MDM2NGMiLz48dGV4dCB4PSIxNjUzIiB5PSI5NzkiIGZvbnQtc2l6ZT0iMjAiIGFsaWdubWVudC1iYXNlbGluZT0ibWlkZGxlIiB0ZXh0LWFuY2hvcj0ibWlkZGxlIiBmaWxsPSJ3aGl0ZSI+MzMwNngxOTU4PC90ZXh0Pjwvc3ZnPg==',
628+
},
629+
{
630+
name: 'Billy Mueller',
631+
632+
image: 'https://avatars.githubusercontent.com/u/55535921',
633+
img: 'data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZlcnNpb249IjEuMSIgYmFzZVByb2ZpbGU9ImZ1bGwiIHdpZHRoPSIzNjQ0IiBoZWlnaHQ9IjI1NjkiPjxyZWN0IHdpZHRoPSIxMDAlIiBoZWlnaHQ9IjEwMCUiIGZpbGw9IiNmNjgwYjEiLz48dGV4dCB4PSIxODIyIiB5PSIxMjg0LjUiIGZvbnQtc2l6ZT0iMjAiIGFsaWdubWVudC1iYXNlbGluZT0ibWlkZGxlIiB0ZXh0LWFuY2hvcj0ibWlkZGxlIiBmaWxsPSJ3aGl0ZSI+MzY0NHgyNTY5PC90ZXh0Pjwvc3ZnPg==',
634+
},
635+
{
636+
name: 'Bobbie Legros',
637+
638+
image: 'https://avatars.githubusercontent.com/u/72438216',
639+
img: 'data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZlcnNpb249IjEuMSIgYmFzZVByb2ZpbGU9ImZ1bGwiIHdpZHRoPSIyNTcwIiBoZWlnaHQ9IjEyNjkiPjxyZWN0IHdpZHRoPSIxMDAlIiBoZWlnaHQ9IjEwMCUiIGZpbGw9IiNlY2I5ZWEiLz48dGV4dCB4PSIxMjg1IiB5PSI2MzQuNSIgZm9udC1zaXplPSIyMCIgYWxpZ25tZW50LWJhc2VsaW5lPSJtaWRkbGUiIHRleHQtYW5jaG9yPSJtaWRkbGUiIGZpbGw9IndoaXRlIj4yNTcweDEyNjk8L3RleHQ+PC9zdmc+',
640+
},
641+
{
642+
name: 'Frederick Lemke',
643+
644+
image: 'https://avatars.githubusercontent.com/u/75817875',
645+
img: 'data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZlcnNpb249IjEuMSIgYmFzZVByb2ZpbGU9ImZ1bGwiIHdpZHRoPSIxOTI0IiBoZWlnaHQ9IjM1MjUiPjxyZWN0IHdpZHRoPSIxMDAlIiBoZWlnaHQ9IjEwMCUiIGZpbGw9IiM3NTJlYWIiLz48dGV4dCB4PSI5NjIiIHk9IjE3NjIuNSIgZm9udC1zaXplPSIyMCIgYWxpZ25tZW50LWJhc2VsaW5lPSJtaWRkbGUiIHRleHQtYW5jaG9yPSJtaWRkbGUiIGZpbGw9IndoaXRlIj4xOTI0eDM1MjU8L3RleHQ+PC9zdmc+',
646+
},
647+
];
648+
}

0 commit comments

Comments
 (0)