Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is ember-cli-moment-shim still required for ember-moment? #369

Open
rreckonerr opened this issue Nov 22, 2021 · 3 comments
Open

Is ember-cli-moment-shim still required for ember-moment? #369

rreckonerr opened this issue Nov 22, 2021 · 3 comments

Comments

@rreckonerr
Copy link

Hi! Thanks for taking care of this addon!
I wonder whether the https://github.com/jasonmit/ember-cli-moment-shim is still required for ember-moment?

In case it DOES NOT, should we remove the blueprint?

In case it DOES, should we update ember-cli-moment-shim to the latest v3.8.0 in the blueprint?

ember-cli-moment-shim v3.4.0 is a blocker for upgrading to the latest ember versions since it relies on [email protected].

ATM I upgraded to the latest ember-moment v9.0.1, removed ember-cli-moment-shim, and don't see any downsides so far.

@jrjohnson
Copy link

I'm seeing the same and trying to figure out if I need to put time into updating and maybe maintaining moment-shim. It doesn't seem to be necessary possibly due to auto-import or something else?

@NullVoxPopuli
Copy link
Collaborator

You both are correct, shim is no longer needed.

@jrjohnson
Copy link

It looks like v10 now provides the tools/documentation needed to provide timezones and locales which were the last parts I was having trouble removing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants