Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ember-classic-decorator package for Ember 5 compatibility #839

Open
gokolo opened this issue Aug 5, 2024 · 0 comments
Open

Remove ember-classic-decorator package for Ember 5 compatibility #839

gokolo opened this issue Aug 5, 2024 · 0 comments

Comments

@gokolo
Copy link

gokolo commented Aug 5, 2024

While upgrading our app to Ember 5.4.0 we encountered errors originating from ember-light-table's use of ember-classic-decorator. We found that the ember-classic-decorator package is not compatible with Ember 5.x.
See this Discord thread for more context.

Opened a PR to remove it from the ember-light-table to make it work on Ember 5 projects.

Also found that ember-scrollable also uses ember-classic-decorator.
A reminder that the forked version of ember-scrollable by @RobbieTheWagner used in ember-light-table's has not been merged upstream yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant