Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ever expanding .tse-scroll-content height value... #725

Open
melriffe opened this issue Nov 14, 2019 · 3 comments
Open

Ever expanding .tse-scroll-content height value... #725

melriffe opened this issue Nov 14, 2019 · 3 comments

Comments

@melriffe
Copy link

This is mostly a request to help debug this issue because there is where my lack of Javascript and CSS experience is glaring.

Background:

  • Ember 2.18.x
  • ember-light-table 1.13.2
  • exhibited in Brave Browser and Safari Browser

Issue:
I have a component that hosts a "table" component and an "editor" component. The "table" component hosts an instance of ember-light-table (mostly 'by the book' but for specific changes for headers and data, and so). I have a clickable icon that switches the view from "table" to "editor" back to "table". The initial view of the table looks as one would expect. However, after switching back from the "editor" there is a visible space between the header row and the first row of data.

When viewing the element in the inspector I can see it's height attribute getting continuously increased.

Request:
Right now I have no idea how to debug this issue. I'm not sure what would cause this behavior.

I can provide additional details if needed, but any assistance will be greatly appreciated!

@melriffe
Copy link
Author

A follow-up, of sorts.

Looks like I can trigger this behavior when resizing the window. It appears an endless loop is created whereby the div with the .tse-scroll-content class has its height updated. That element is created by the ember-scrollable addon/dependency.

Debugging JavaScript is not a strong point for me. Any ideas what would/could cause this endless loop? Any ideas on how I might be able to debug this better?

@melriffe
Copy link
Author

(Hopefully) Final update.

It appears the vendor.css reference was removed from index.html, causing all kinds of weirdness since the .ember-light-table styles were not present. Adding this back in seems to have fixed this issue.

Thank you for your time.

@melriffe
Copy link
Author

Question: How can I include the ember-light-table styles in my app.scss like I can with ember-bootstrap: @import "ember-bootstrap/bootstrap";

@melriffe melriffe reopened this Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant