-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
querySelector errors when resizing columns in 2.x #719
Comments
@cwsault Thanks for reporting I'll try and look into this soon and hopefully ship a fix with beta5 |
@fran-worley FWIW, I think there may exist a deeper-running issue with resizing at the moment as well -- I tried adding in null checks locally (and also just adding some cells matching the selector to an extra table header/footer...), and while it does fix the errors, the header will only resize once (meaning until the mouse is released -- it expand and shrink freely until then). Once released, future attempts to resize the same column only resize the main table cells, while the header cell remains the same size. It seems to be that during resizing, the |
I found few issues with the resizing(2.x), including:
...I believe I already fixed all of those. I hope I will be able to make a PR tomorrow once I test everything. |
@offirgolan @fran-worley Could you take a look at the fix I provided? We need this issue to be fixed, would be great to know when can we expect new version :) |
Using
ember-light-table
version2.0.0-beta.4
and Ember 3.9, I am seeing these thrown when using the resize handles to alter a column's width, which breaks any following attempts to resize the same column:It appears that the selectors here in /addon/components/lt-column-resizer.js are not finding a matching element and thus triggering the error -- compare to pre-2.x which used jQuery instead of querySelector, which IIRC will not error out if the selector fails. I'd guess this difference is most likely causing this issue.
Also to note, I attempted to work around this by turning on
enableScaffolding
in the table body, but it seems to still not generate the scaffolding cells -- poking around the templates, it seems these might only generate in the header when using sub-columns (I'm providing a flat column array).The text was updated successfully, but these errors were encountered: