Getting started guidance and support for angle bracket syntax #688
Comments
|
@mshirey without some idea of the code you've put together it'll be pretty hard for anyone to help! Can you post an extract or reproduction? |
|
Hi Alex,
Thank you for the reply. Yes, I’ve looked through the supplied links an none actually explain what this error is or help to provide any indication of why I’m encountering it. I found the “ember-light-table-hello-world” repo while researching Ember Light Table and while it is a little helpful, it contains a number of errors and inconsistencies that keep it from being the valuable resource it could be. It’s a good start though. Ultimately, I found no help for this error other than replies, like yours, which amount to “You did it wrong”, but don’t really offer an explanation or an indication of how or where I might have made a wrong turn. What would be helpful is a troubleshooting list of possible ways this error is encountered. Since this seems to be rather common, what is it about the usage of Ember Light Table that commonly results in this error?
What I can do to help you is to explain how I encountered this error and how I resolved the issue. For me, I was trying to use angle brackets format instead of handlebars. We’ve converted all of our projects to angle brackets and prefer to not have mixed format in our templates. Once I converted my code back to using handlebars, the error was no longer present. This however is not the desired result as now I have a mixed format in my template. Will Ember Light Table work using angle brackets syntax? If so, could you provide any hints or tips on any issues you’re aware of?
On a semi-related topic, I’d recommend the removal of the use of mix-ins from the provided examples. It looks like it’s a point of confusion for some developers, and at least in my opinion, isn’t needed to explain the use of the Table. Maybe leave these to an “advanced” section?
Thank you,
…-- Matthew
From: Alex Alvarez
Sent: Monday, May 20, 2019 10:40 AM
Subject: Re: [offirgolan/ember-light-table] Error: Assertion Failed:[ember-light-table] table must be an instance of Table (#688)
@mshirey sorry about that. did you track through the other issues with the same problem and how we helped them fixed it?
#544 (and the ones referenced in that one)
this assertion means that you're not properly ivoking the addon which has been an issue others have come across also
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Thanks @mshirey for debugging all that, and sorry you had the issues.
Is very helpful for us to be able to answer your questions. If we new what you were experiencing we would have prevented it from happening. Generally speaking that assertion is hit when the table isn't passed in. I'd have to investigate more to give you a definite answer as to what happened. The intent is to support angle bracket usage. If it doesn't, PRs with failing test cases are great ways to kick-start bugfixes from those with free time.
Definitely. It seems people are keen on copy-pasting and miss he common logic form the mix-in. The logic has been there to prevent copy pasta on our demo applications, but frequently enough people stumble on it that I believe it outweighs the maintenance burden related to it. |
|
@mshirey @alexander-alvarez I'm just working through updating dependencies for ELT which includes emberjs and ember cli. Once I've done this we can turn our attention to 'officially' supporting angle bracket syntax. I believe we can pull in the work started here for the docs #670 though we should probably add some tests too for good measure! |
Thank you so much @fran-worley . I can confirm that I ran into the "Error: Assertion Failed: [ember-light-table] table must be an instance of Table" issue working through the ember-light-table-hello-world example. All I did was convert the handlebars to angle brackets. Once I encountered the error, on a hunch, I switched it back to handlebars and the error resolved itself. I don't have that code anymore, but I can reproduce it if it would be helpful. |
|
Thats really helpful @mshirey I think the answer is probably for us to add a getting started page into the cookbook https://offirgolan.github.io/ember-light-table/#/cookbook . I think you've pointed us in the direction of how you hit this error so that should be enough to go on for now. As a side point if you're trying to use ember-light-table in a >3.1 ember project I would advise you to checkout the 2.x branch as that is where we're applying fixes for deprecations etc. |
fran-worley
changed the title
|
@mshirey I suspect you've moved on by now but I've got Angle Brackets working on the 2.x branch in our dummy app. Please see the following file for a simple example. The docs will be updated in the next couple of weeks as we release v2.0.0 (see #739) |
Error: Assertion Failed: [ember-light-table] table must be an instance of Table
Getting this error while I've confirmed we are creating an instance of the Table. This is a seriously uninformative error that has left us at a brick wall. We've followed the documentation as best as we could and used supplimental materials such as (https://github.com/Stoiker/ember-light-table-hello-world) as well as digging through the dummy app code. At this point I'd beg for updated / clearer documentation. This table looks like it is very nice and has great potential, but right now, we cannot even get out of the starting gate.
The text was updated successfully, but these errors were encountered: