Skip to content

Commit 846d1e5

Browse files
committed
fixing more cases for get params match
1 parent 75a049c commit 846d1e5

File tree

2 files changed

+13
-2
lines changed

2 files changed

+13
-2
lines changed

addon/utils/helper-functions.js

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,23 @@ export function toGetParams(obj) {
3333
let convertedParams = Object.assign({}, obj);
3434
Object.keys(convertedParams).forEach(key => {
3535
let value = convertedParams[key];
36-
if (Array.isArray(value)) {
36+
if (typeOf(value) === 'array') {
3737
convertedParams[key] = value.map(v => String(v));
3838
}
3939
if (typeof value === 'number') {
4040
convertedParams[key] = String(value);
4141
}
42+
if (typeof value === 'boolean') {
43+
convertedParams[key] = String(value);
44+
}
45+
if (typeOf(value) === 'object') {
46+
Object.keys(value).forEach((vKey) => {
47+
let pKey = `${key}[${vKey}]`,
48+
vValue = value[vKey];
49+
convertedParams[pKey] = String(vValue);
50+
});
51+
delete convertedParams[key];
52+
}
4253
});
4354
return convertedParams;
4455
}

tests/unit/mocks/mock-any-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ module('MockAny', function(hooks) {
101101
test("GET with url params", async function(assert) {
102102
const type = 'GET',
103103
url = '/api/get-stuff',
104-
whatsUp = {whats: 'up', dudes: [1], dude: 1},
104+
whatsUp = {whats: 'up', dudes: [1], dude: 1, awake: true, keys: {e: 1}},
105105
whatsUpDoc = {whats: 'up doc'};
106106

107107
let theMock = mock({url}).withParams(whatsUp).returns(whatsUp);

0 commit comments

Comments
 (0)