Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating NPM Dependencies to remove Deprecation Warnings #169

Open
Alonski opened this issue Mar 21, 2018 · 0 comments
Open

Updating NPM Dependencies to remove Deprecation Warnings #169

Alonski opened this issue Mar 21, 2018 · 0 comments

Comments

@Alonski
Copy link
Member

Alonski commented Mar 21, 2018

While trying to update an app that uses this addon to v3.0.0 I ran into this deprecation:
An addon is trying to access project.nodeModulesPath. This is not a reliable way to discover npm modules. Instead, consider doing: require("resolve").sync(something, { basedir: project.root }). Accessed from:

This needs to be fixed so that projects using this addon can upgrade to v3.0.0.

This should fix it:
Upgrade the version checker: ember-cli/ember-cli-version-checker#48

In the current release of this addon 1.0.0-alpha.8 it is using a few addons that need to be updated for this deprecation to go away. These are:

  1. Ember CLI Deploy GHPages
  2. Layout Bin Packer

About Ember CLI Deploy GHPages, I made a PR to them to fix this and updated the addon to Ember v2.18.2: VerdigrisTech/ember-cli-deploy-ghpages#8

About Layout Bin Packer, this has been fixed in master but a new release needs to be put out:
stefanpenner/layout-bin-packer#29

Is Ember CLI Deploy GHPages still needed by this project? Currently I don't think there is a GHPage branch that works.

If not I can finish my branch and create a PR:
https://github.com/Alonski/ember-collection/tree/update-dependencies

Also last thing... I removed Bower as a dependency. Don't think it is needed anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant