Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index not updated properly #115

Open
ghedamat opened this issue May 1, 2016 · 3 comments
Open

index not updated properly #115

ghedamat opened this issue May 1, 2016 · 3 comments

Comments

@ghedamat
Copy link

ghedamat commented May 1, 2016

Hi!

I'm in the process of updating what @cibernox did here https://github.com/cibernox/ember-power-select-collection

In its newest version ember-power-select relies on the index yielded property of the #each helper.

It appears that this is not playing super well with ember-collection and when power-select filters the list the indexes are not updated properly.

ember-collection exposes an index but maybe I'm simply misunderstanding its functionality?

I'll try to create a reproduction repository as soon as I can, in the meantime here's a video from this happening in my company's app

https://gsnaps.s3.amazonaws.com/screencast_2016-05-01_18-02-50.mp4

I'm rendering only the indexes in the list instead of the full content and you can see they're not contiguous

thanks!

@ghedamat
Copy link
Author

ghedamat commented May 1, 2016

also to be noted, I have a workaround for ember-power-select that doesn't rely on the index property but I still wonder if index is correct

@raytiley
Copy link
Contributor

raytiley commented May 2, 2016

Related: #110

Sorry, just haven't had time to figure out why those tests are failing, but basically when reusing cells we aren't updating the index that gets exposed.

@ghedamat
Copy link
Author

ghedamat commented May 2, 2016

@raytiley no problem, I missed that #110 was the same.

As mentioned I have a workaround for now anyway.

Thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants