Skip to content

[Bug]: Dialogs opened with sp-overlay type="page" can be dismissed with Android back #4840

Open
@hooplapunta

Description

@hooplapunta

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

sp-overlay, sp-dialog-base

Expected behavior

Any dialogs opened with an overlay indicating type of "page" - i.e. do not allow dismissal: should not be dismissed with the Android back button.

Actual behavior

Dialog attribute open is removed and dialog, sp-dialog-base, sp-overlay also no longer have "open" after an Android back button.

Screenshots

No response

What browsers are you seeing the problem in?

Chrome

How can we reproduce this issue?

behavior can be observed on basic
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dialog

open dialog
use android back button to close - navigator is not triggered
same applies to any sp-dialog etc.

This is allowing users in Adobe Express to skip the landscape blocker dialog when the phone is rotated to landscape. Other similar workflows as well.

Sample code or abstract reproduction which illustrates the problem

whatwg/html#5667 (comment)
https://html.spec.whatwg.org/multipage/interaction.html#close-requests-and-close-watchers

behavior can be observed on basic
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dialog

Severity

SEV 2

Logs taken while reproducing problem

No response

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions