Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vega-embed relies on fast-json-patch which does not get hoisted properly by parcel #346

Open
marshallpete opened this issue Jun 11, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@marshallpete
Copy link
Member

Provide a general summary of the issue here

vega-embed has a dependency on fast-json-patch which does not currently get hoisted correctly in parcel. vega-embed also has vega-lite as a required dependency which is almost a 10MB package that we never use.

🤔 Expected Behavior?

react-spectrum-charts will work in parcel production builds without special package.json setup.

😯 Current Behavior

parcel apps need to add an alias to their package.json that points to the index.js file for fast-json-patch instead of the index.mjs file.

💁 Possible Solution

Remove our dependency on vega-embed by reimplementing the necessary parts in react-spectrum-charts

🔦 Context

No response

🖥️ Steps to Reproduce

  1. Create a simple parcel app
  2. Add fast-json-patch
  3. Serve with hoisting enabled

Version

v1.10.1

What browsers are you seeing the problem on?

Chrome

If other, please specify.

No response

What operating system are you using?

Mac OS 14.5

🧢 Your Company/Team

Adobe

🕷 Tracking Issue

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant