Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

munge together acquired companies or no? #2

Open
filmaj opened this issue Feb 20, 2019 · 6 comments
Open

munge together acquired companies or no? #2

filmaj opened this issue Feb 20, 2019 · 6 comments
Labels
bigquery need bigquery sql help bug Something isn't working help wanted Extra attention is needed question Further information is requested

Comments

@filmaj
Copy link
Contributor

filmaj commented Feb 20, 2019

We do so right now with Magento + Adobe (we count anyone who has "Magento" in their company profile name as an Adobe employee). There are open questions as to whether or not to do this for IBM+RedHat and MSFT+GitHub.

Doing so at data-scraping-time destroys valuable info: how much of a company's activity is contributed to by an acquired company? It would be better to allow to delineate between this information.

One option: these 'mungings' could be applied at the BigQuery level. That way, at BigQuery-time, we can choose to run analyses that delineate (or not) acquired companies.

@filmaj filmaj added the enhancement New feature or request label Feb 20, 2019
@fhoffa
Copy link

fhoffa commented Feb 21, 2019

My 2 cents: I would keep GitHub and Red Hat as separate entities, as long as they choose to be separate independent entities.

Likewise, I would count Amazon and The Washington Post as separate entities, and not as "Jeff Bezos".

Per official communications, GitHub will get its own CEO. Meanwhile IBM promised to keep Red Hat independent. I also expect employees to strongly identify with one vs the other - so I would respect that.

@filmaj
Copy link
Contributor Author

filmaj commented Feb 22, 2019

I think you're right on this @fhoffa. We had a conversation about this internally at Adobe and waffled between doing it and not. Ultimately @mjasay asked to put GitHub+MSFT and RedHat+IBM together, and it's a good idea to listen to my boss 😉

Worthy of a conversation for sure. I'm happy to revert / update the user/company table I use in bigquery based on whatever shakes out here.

@fhoffa
Copy link

fhoffa commented Feb 22, 2019

It's all about incentives :)

On acquisitions gone wrong, see TravisCI. Acquired by Idera a month ago, yesterday they started laying off a big chunk of their employees, including their most senior engineers. I would not give Idera any credit for open source contributions, even if they payed money for this company. Now, instead of using my best criteria, we can let people choose if they want to change their profile to Idera - then we respect that choice.

Now, it would be great to have a second table for roll ups - in case people want to do the rollup and merge companies according to their best judgement.

@mjasay
Copy link

mjasay commented Feb 22, 2019 via email

@filmaj
Copy link
Contributor Author

filmaj commented Feb 23, 2019

Now, instead of using my best criteria, we can let people choose if they want to change their profile to Idera - then we respect that choice.

This nails it. We should change companies.js simple regex matching not to count companies based on acquisitions. Rather, it should be used as a means of massaging what the user profiles intend to communicate. That said, I think we can continue to use the munges for things like counting '🍏' as 'Apple Inc.', or counting all of 'AWS', 'AMZN' and 'Amazon' as 'Amazon'.

I think I'd want to see what changes/additions would need to be made in the (Big)SQL queries revisioned under db/ to formalize those 'delineate or not' queries. Maybe we could work on a PR for this?

@filmaj filmaj added bug Something isn't working help wanted Extra attention is needed question Further information is requested and removed enhancement New feature or request labels Feb 23, 2019
@filmaj filmaj added the bigquery need bigquery sql help label Mar 2, 2019
@pabelanger
Copy link
Contributor

IBM does not own Red Hat right now, so it is currently incorrect to lump these two companies together. Until the acquisition is complete 090b172 should be reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bigquery need bigquery sql help bug Something isn't working help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants