[aws] ci deploy branch changes existing function configuration

[dominique-pfister]

When executing a CI build (step branch-deploy), one can see that the function configuration is updated:

https://app.circleci.com/pipelines/github/adobe/helix-s3r2-sync/575/workflows/988a84ff-7b27-4d21-b046-c8a4b2ca50ff/jobs/1257

Look for the line:

updating existing Lambda function configuration helix-services--s3r2-sync

in code this happens here:

helix-deploy/src/deploy/AWSDeployer.js

Line 267 in 04c455a

await this._lambda.send(new UpdateFunctionConfigurationCommand(functionConfig));

I think this causes newly started function invocations of the main function to use that CI configuration, which is unexpected.

cc: @stefan-guggisberg

[tripodsan]

let's consider this as a known issue and document it.