test: AnalysisTemplate no longer requires metrics

use provider field

Author: Carlos Sanchez

test/argo-rollouts/analysistemplate.bats

@@ -4,18 +4,36 @@ load ../test_helper
 
 @test "valid AnalysisTemplate" {
   run kubeval "${FIXTURES}/valid.yaml"
-  [[ $status -eq 0 ]]
-  [[ $output = "PASS - ${FIXTURES}/valid.yaml contains a valid AnalysisTemplate (test.test)" ]]
+  [[ $status -eq 0 ]] || {
+    echo "Output: $output"
+    exit 1
+  }
+  [[ $output = "PASS - ${FIXTURES}/valid.yaml contains a valid AnalysisTemplate (test.test)" ]] || {
+    echo "Output: $output"
+    exit 1
+  }
 }
 
 @test "invalid AnalysisTemplate" {
   run kubeval "${FIXTURES}/invalid.yaml"
-  [[ $status -eq 1 ]]
-  [[ $output = "WARN - ${FIXTURES}/invalid.yaml contains an invalid AnalysisTemplate (test.test) - metrics: metrics is required" ]]
+  [[ $status -eq 1 ]] || {
+    echo "Output: $output"
+    exit 1
+  }
+  [[ $output = "WARN - ${FIXTURES}/invalid.yaml contains an invalid AnalysisTemplate (test.test) - provider: provider is required" ]] || {
+    echo "Output: $output"
+    exit 1
+  }
 }
 
 @test "invalid AnalysisTemplate in strict mode" {
   run kubeval --strict "${FIXTURES}/strict.yaml"
-  [[ $status -eq 1 ]]
-  [[ $output = "WARN - ${FIXTURES}/strict.yaml contains an invalid AnalysisTemplate (test.test) - invalid-key: Additional property invalid-key is not allowed" ]]
+  [[ $status -eq 1 ]] || {
+    echo "Output: $output"
+    exit 1
+  }
+  [[ $output = "WARN - ${FIXTURES}/strict.yaml contains an invalid AnalysisTemplate (test.test) - invalid-key: Additional property invalid-key is not allowed" ]] || {
+    echo "Output: $output"
+    exit 1
+  }
 }

test/argo-rollouts/analysistemplate/invalid.yaml

@@ -4,4 +4,6 @@ kind: 'AnalysisTemplate'
 metadata:
   name: 'test'
   namespace: 'test'
-spec: {}
+spec:
+  metrics:
+  - name: success-rate

test/argo-rollouts/clusteranalysistemplate.bats

@@ -4,18 +4,36 @@ load ../test_helper
 
 @test "valid ClusterAnalysisTemplate" {
   run kubeval "${FIXTURES}/valid.yaml"
-  [[ $status -eq 0 ]]
-  [[ $output = "PASS - ${FIXTURES}/valid.yaml contains a valid ClusterAnalysisTemplate (test.test)" ]]
+  [[ $status -eq 0 ]] || {
+    echo "Output: $output"
+    exit 1
+  }
+  [[ $output = "PASS - ${FIXTURES}/valid.yaml contains a valid ClusterAnalysisTemplate (test.test)" ]] || {
+    echo "Output: $output"
+    exit 1
+  }
 }
 
 @test "invalid ClusterAnalysisTemplate" {
   run kubeval "${FIXTURES}/invalid.yaml"
-  [[ $status -eq 1 ]]
-  [[ $output = "WARN - ${FIXTURES}/invalid.yaml contains an invalid ClusterAnalysisTemplate (test.test) - metrics: metrics is required" ]]
+  [[ $status -eq 1 ]] || {
+    echo "Output: $output"
+    exit 1
+  }
+  [[ $output = "WARN - ${FIXTURES}/invalid.yaml contains an invalid ClusterAnalysisTemplate (test.test) - provider: provider is required" ]] || {
+    echo "Output: $output"
+    exit 1
+  }
 }
 
 @test "invalid ClusterAnalysisTemplate in strict mode" {
   run kubeval --strict "${FIXTURES}/strict.yaml"
-  [[ $status -eq 1 ]]
-  [[ $output = "WARN - ${FIXTURES}/strict.yaml contains an invalid ClusterAnalysisTemplate (test.test) - invalid-key: Additional property invalid-key is not allowed" ]]
+  [[ $status -eq 1 ]] || {
+    echo "Output: $output"
+    exit 1
+  }
+  [[ $output = "WARN - ${FIXTURES}/strict.yaml contains an invalid ClusterAnalysisTemplate (test.test) - invalid-key: Additional property invalid-key is not allowed" ]] || {
+    echo "Output: $output"
+    exit 1
+  }
 }

test/argo-rollouts/clusteranalysistemplate/invalid.yaml

@@ -4,4 +4,6 @@ kind: 'ClusterAnalysisTemplate'
 metadata:
   name: 'test'
   namespace: 'test'
-spec: {}
+spec:
+  metrics:
+  - name: success-rate