unfork Rex

[alip]

Issue to track the progress of unforking Rex.
Obsoletes: #21

[alip]

Patches waiting on upstream:

• LibVirt: Initial support for virtio-scsi virtual drives (read: ssd trim) RexOps/Rex#1467: LibVirt: Initial support for virtio-scsi virtual drives (read: ssd trim)
• Shell.pm: add iLO support RexOps/Rex#1468: Shell.pm: add iLO support
• Shell.pm: add iDRAC 4.00.00.00 support RexOps/Rex#1469: Shell.pm: add iDRAC 4.00.00.00 support
• Add ability to pass options to openssh via REX_OPENSSH_OPTS RexOps/Rex#1470: Add ability to pass options to openssh via REX_OPENSSH_OPTS
• Allow uploading files even when permissions cannot be set. RexOps/Rex#1471: Allow uploading files even when permissions cannot be set
• t/issue/948.t: Fixing whitespace detection in test RexOps/Rex#1472: t/issue/948.t: Fixing whitespace detection in test

Patches which require more work and/or investigation before submitting to upstream:

• ebdb350: Revert (breaks hooks): fix bug with before => ALL in modules
• a3e2b4b: Revert (breaks needs): use Task::run() method to call the task code.

[alip]

I had a meeting with upstream about the patchset, here's a rough estimate on how we want to move forward:

Patches waiting on upstream:

* [RexOps#1467](https://github.com/RexOps/Rex/pull/1467): LibVirt: Initial support for virtio-scsi virtual drives (read: ssd trim)
* [RexOps#1472](https://github.com/RexOps/Rex/pull/1472): t/issue/948.t: Fixing whitespace detection in test

We want to merge these two PRs into one.

* [RexOps#1468](https://github.com/RexOps/Rex/pull/1468): Shell.pm: add iLO support
* [RexOps#1469](https://github.com/RexOps/Rex/pull/1469): Shell.pm: add iDRAC 4.00.00.00 support

First we want to consider the option of submitting these two to CPAN as modules rather than having them in core Rex.
As an example of such a module, see: Rex::Hook::File::Diff.

* [RexOps#1470](https://github.com/RexOps/Rex/pull/1470): Add ability to pass options to openssh via REX_OPENSSH_OPTS

According to upstream, Net::OpenSSH uses openssh binary which honours ssh_config(5) so the issue to force IPv4 which was a motivation behind this PR may also be established with e.g:

Host *.adjust.com
    AdressFamily inet

in ~/.ssh/config. This, however, is not guaranteed to work and needs to be verified (and I vaguely recall this did not work for us back in the day).

* [RexOps#1471](https://github.com/RexOps/Rex/pull/1471): Allow uploading files even when permissions cannot be set

Upstream wants to have a configuration item for this to specify intent rather than using best effort unconditionally when sudo is not present.

Patches which require more work and/or investigation before submitting to upstream:

* [ebdb350](https://github.com/adjust/Rex/commit/ebdb350bdc827961fd0414f9c5cfe994fc41cb2a): Revert (breaks hooks): fix bug with before => ALL in modules

* [a3e2b4b](https://github.com/adjust/Rex/commit/a3e2b4b21d0fbac35e9997425f88ea76cedf1364): Revert (breaks needs): use Task::run() method to call the task code.

According to upstream, these two issues have already been fixed in the latest version and master but this should be verified.

[alip]

According to upstream, Net::OpenSSH uses openssh binary which honours ssh_config(5) so the issue to force IPv4 which was a motivation behind this PR may also be established with e.g:

Host *.adjust.com
    AdressFamily inet

in ~/.ssh/config. This, however, is not guaranteed to work and needs to be verified (and I vaguely recall this did not work for us back in the day).

Setting AddressFamily in ~/.ssh/config works so RexOps#1470 is not necessary.
I'll document this under engineering docs.

[alip]

Setting AddressFamily in ~/.ssh/config works so RexOps#1470 is not necessary.
I'll document this under engineering docs.

adjust/engineering_documentation#118

[alip]

Patches which require more work and/or investigation before submitting to upstream:

• ebdb350: Revert (breaks hooks): fix bug with before => ALL in modules

Confirmed this has already been fixed in rex-1.13.2 so the revert is no longer necessary.

[alip]

Patches which require more work and/or investigation before submitting to upstream:

• a3e2b4b: Revert (breaks needs): use Task::run() method to call the task code.

Confirmed this has already been fixed in rex-1.13.2 so the revert is no longer necessary.

[alip]

* [RexOps#1468](https://github.com/RexOps/Rex/pull/1468): Shell.pm: add iLO support
* [RexOps#1469](https://github.com/RexOps/Rex/pull/1469): Shell.pm: add iDRAC 4.00.00.00 support

First we want to consider the option of submitting these two to CPAN as modules rather than having them in core Rex.

As an example of such a module, see: Rex::Hook::File::Diff.

Discussed this with @einhverfr, we want to submit the modules to CPAN and comaintain them.

Added two git repositories to host the modules:

• adjust/Rex-Interface-Shell-Idrac4
• adjust/Rex-Interface-Shell-Ilo

Asked upstream to review these git repositories before release and updated upstream PRs to create mappings in Shell.pm which point to these modules.

[alip]

Added two git repositories to host the modules:

* [adjust/Rex-Interface-Shell-Idrac4](https://github.com/adjust/Rex-Interface-Shell-Idrac4)

* [adjust/Rex-Interface-Shell-Ilo](https://github.com/adjust/Rex-Interface-Shell-Ilo)

Asked upstream to review these git repositories before release and updated upstream PRs to create mappings in Shell.pm which point to these modules.

Changes made folliowing the comments of upstream, submitted to CPAN, added @einhverfr and @blueSherii as co-maintainers:

• Rex::Interface::Shell::Idrac4
• Rex::Interface::Shell::Ilo