Skip to content

package.json vs package-request.json in the media buy process #750

@marekjalovec

Description

@marekjalovec

core/package.json defines impressions field which is defined as the following:

    "impressions": {
      "type": "number",
      "description": "Impression goal for this package",
      "minimum": 0
    },

This is inconsistent with media-buy/package-request.json and media-buy/update-media-buy-request.json as neither of these define the impressions, so it's impossible to set this value for media buy packages.


Further inconsistencies worth considering:

  • format_ids in media-buy/package-request.json vs format_ids_to_provide in code/package.json (this one might be intentional?)
  • missing paused in media-buy/package-request.json, so it always defaults to false as per core/package.json definition without an option to set it initially

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions