-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TCA issue computing matrix #126
Comments
Hi @etiennevandebijl, But maybe the adapt documentation is wrong, it is written that "The larger mu is, the less adaptation is performed." but it may be the opposite... |
Thank you for looking into this. Indeed, in this unpublished version of the article proposing TCA, it is written as np.eye(n+m) + self.mu * K.dot(L.dot(K)). However, in the published peer-reviewed version of TCA it is K.dot(L.dot(K)) + self.mu * np.eye(n+m), see page 204 right above Algorithm 1. It doesn't unfortunately result in the same result, but I think it might be a choice of which work to implement... |
Hi @etiennevandebijl, |
Hi,
I am implementing TCA and saw an issue in line 126 of _tca.py file:
Implemented is the following:
a = np.eye(n+m) + self.mu * K.dot(L.dot(K))
However, according to the authors, it should be: K.dot(L.dot(K)) + self.mu * np.eye(n+m) (mu should be multiplied with the identity matrix)
I hope this helps.
The text was updated successfully, but these errors were encountered: