Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keepalive_time_ms parameter in flwr.server.app.start_server #4128

Open
JonathanChen1002 opened this issue Sep 3, 2024 · 1 comment
Open

Add keepalive_time_ms parameter in flwr.server.app.start_server #4128

JonathanChen1002 opened this issue Sep 3, 2024 · 1 comment
Labels
feature request This issue or comment suggests an additional feature. part: communication Issues/PRs that affect federated communication e.g. gRPC. stale If issue/PR hasn't been updated within 3 weeks.

Comments

@JonathanChen1002
Copy link

JonathanChen1002 commented Sep 3, 2024 •
edited
Loading

Describe the type of feature and its functionality.

Hi, I've encountered a situation where we need to set a shorter keep alive time when start grpc server.
I noticed that flwr.server.app.start_server use start_grpc_server function, which has keepalive_time_ms parameter.
Is it possible to add this parameter in flwr.server.app.start_server?

Describe step by step what files and adjustments are you planning to include.

add keepalive_time_ms parameter in flwr.server.app.start_server and pass it to start_grpc_server function

Is there something else you want to add?

No response
@JonathanChen1002 JonathanChen1002 added the feature request This issue or comment suggests an additional feature. label Sep 3, 2024
@WilliamLindskog WilliamLindskog added stale If issue/PR hasn't been updated within 3 weeks. part: communication Issues/PRs that affect federated communication e.g. gRPC. labels Dec 11, 2024
@WilliamLindskog
Copy link
Contributor

@jafermarq is this something we should consider?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request This issue or comment suggests an additional feature. part: communication Issues/PRs that affect federated communication e.g. gRPC. stale If issue/PR hasn't been updated within 3 weeks.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@WilliamLindskog @JonathanChen1002