Respect path in import #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ondrej Vasko <[email protected]>
Import didn't respect path where user wanted to import the backup. By saving only relative path in export and prepending the desired path in import it could be easily respected. Signed-off-by: Ondrej Vasko <[email protected]>
|
LGTM. Have you tried this on a dev/real instance? |
|
Hello @adamdecaf, yes I'm using it for vault backups (Disaster Recovery) in my company. I could possibly add some test if that is needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR closes #20.
Path stored during export is changed to be relative and during import, the user specified path is prepended to it.
Changes in vendor are result of
go mod vendor.