Encountered Error Does Not Report as Error

[Mike-E-angelo]

From #36:

https://github.com/ExtendedXmlSerializer/home/runs/330624066

(Under Push Changes)

Started: bash /home/runner/work/_actions/ad-m/github-push-action/master/start.sh
Push to branch master
remote: error: GH006: Protected branch update failed for refs/heads/master.        
remote: error: Required status check "continuous-integration/appveyor/pr" is expected.        
To https://github.com/ExtendedXmlSerializer/home.git
 ! [remote rejected]   HEAD -> master (protected branch hook declined)
error: failed to push some refs to '***github.com/ExtendedXmlSerializer/home.git'

Here is our configuration:
https://github.com/ExtendedXmlSerializer/home/blob/47f7567de9a45f849ffa106bd391d11026b8a2eb/.github/workflows/publish-release-build.yml#L49-L52

The action encountered an error, but it still passed as if an error did not occur. Ideally, the job should fail if the action encountered any error while attempting to complete its primary objective.

Please let me know if I have something fundamentally misunderstood and/or configured incorrectly.

[Pro]

Same issue here.

Push failed, but action returned success:
https://github.com/opcua-skills/skill-nodeset/commit/b55f4bdd93dae27cc1365925e440721f9b87d53f/checks?check_suite_id=343435102

Run ad-m/github-push-action@master
  with:
    branch: testing-published
    force: true
    github_token: ***
    directory: .
Started: bash /home/runner/work/_actions/ad-m/github-push-action/master/start.sh
Push to branch testing-published
error: The destination you provided is not a full refname (i.e.,
starting with "refs/"). We tried to guess what you meant by:

- Looking for a ref that matches 'testing-published' on the remote side.
- Checking if the <src> being pushed ('HEAD')
  is a ref in "refs/{heads,tags}/". If so we add a corresponding
  refs/{heads,tags}/ prefix on the remote side.

Neither worked, so we gave up. You must fully qualify the ref.
hint: The <src> part of the refspec is a commit object.
hint: Did you mean to create a new branch by pushing to
hint: 'HEAD:refs/heads/testing-published'?
error: failed to push some refs to '***github.com/opcua-skills/skill-nodeset.git'

[ckipp01]

Just came across this, and it's a bit confusing if you don't look closely. For example, at a quick glance, there were no issues, everything was green. However, when you look close, it failed on this stage but didn't report it as such.

[russkel]

Could this be because the action wrapped in start.js and the error code is not being passed on?
Does this action need start.js?

[ad-m]

Could somebody with that issue verify pull request #45?

[russkel]

@ad-m I just made my auth token slightly wrong and it seems to error :)!

https://github.com/russkel/moos-ivp/runs/424306848?check_suite_focus=true

Thanks!

[ad-m]

Merged to master fix. If I receive more reports that everything works or other changes appear, or if some of the contributors feel like do it, a new release will be created.