Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Convert FixEncryptionKey, Loading, AnimatedLoading components to TypeScript #1784

Merged
merged 4 commits into from
Oct 19, 2023

Conversation

MikesGlitch
Copy link
Contributor

@MikesGlitch MikesGlitch commented Oct 11, 2023

Convert FixEncryptionKey, Loading, AnimatedLoading components to TypeScript and update get-payee query type.

#1483

@netlify
Copy link

netlify bot commented Oct 11, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 3b9f541
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/652d622395059b0008b334a4
😎 Deploy Preview https://deploy-preview-1784.demo.actualbudget.org/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
16 2.82 MB → 2.82 MB (-6 B) -0.00%
Changeset
File Δ Size
src/components/modals/FixEncryptionKey.tsx 🆕 +7.65 kB 0 B → 7.65 kB
src/icons/Loading.tsx 🆕 +2.05 kB 0 B → 2.05 kB
src/icons/AnimatedLoading.tsx 🆕 +760 B 0 B → 760 B
src/components/modals/FixEncryptionKey.js 🔥 -7.65 kB (-100%) 7.65 kB → 0 B
src/icons/Loading.js 🔥 -2.05 kB (-100%) 2.05 kB → 0 B
src/icons/AnimatedLoading.js 🔥 -753 B (-100%) 753 B → 0 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
static/js/main.js 1.12 MB → 1.12 MB (-6 B) -0.00%

Unchanged

Asset File Size % Changed
static/js/848.chunk.js 760.98 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/713.chunk.js 156.56 kB 0%
static/js/wide-components.chunk.js 126.86 kB 0%
static/js/231.chunk.js 117.37 kB 0%
static/js/narrow-components.chunk.js 43.06 kB 0%
static/js/reports.chunk.js 29.92 kB 0%
static/js/473.chunk.js 13 kB 0%
static/js/389.chunk.js 12.77 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.88 kB 0%
static/css/main.css 7.41 kB 0%
asset-manifest.json 2.07 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 903 B 0%

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 2.22 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.23 MB 0%
xfo.xfo.kcab.worker.js 1014.46 kB 0%

@MikesGlitch MikesGlitch marked this pull request as ready for review October 11, 2023 21:10
@MikesGlitch MikesGlitch changed the title Maintenance: Typescript modals - Encryption key Maintenance: Convert FixEncryptionKey, Loading, AnimatedLoading components to TypeScript Oct 11, 2023
@MatissJanis MatissJanis merged commit eb54487 into actualbudget:master Oct 19, 2023
17 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Oct 19, 2023
@MikesGlitch MikesGlitch deleted the maintenance/ts-modals-2 branch October 19, 2023 07:44
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants