Refactor budget/IncomeGroups to tsx #1690
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
| @@ -33,8 +44,18 @@ function IncomeGroup({ | |||
| onSave={onSave} | |||
| onToggleCollapse={onToggleCollapse} | |||
| onShowNewCategory={onShowNewCategory} | |||
| dragPreview={undefined} | |||
There was a problem hiding this comment.
💬 suggestion: would you mind starting with lower-level components? Or doing multiple components at once?
We already have a bunch of these undefined prop values scattered throughout the codebase because of unfinished migrations. Ideally we should not add more of them.
There was a problem hiding this comment.
Yes I can do that. Thanks for the suggestion.
trafico-bot
bot
added
⚠️ Changes requested
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
This PR was closed because it has been stalled for 5 days with no activity. |
Refactor budget/IncomeGroups to tsx, related to issue #1483