Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MobileTable tsx Refactor #1578

Closed
wants to merge 10 commits into from
Closed

MobileTable tsx Refactor #1578

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
85a3581
add release notes
Jod929 Aug 22, 2023
fb68ce7
update release note file name to match PR number
Jod929 Aug 22, 2023
0a9fb74
refactor components/budget/MobileTable to ts
Jod929 Aug 23, 2023
c0df1a8
add release notes for MobileTable refactor
Jod929 Aug 23, 2023
95f25fe
rename release note to PR number
Jod929 Aug 23, 2023
4a6e46d
change release notes name to PR number
Jod929 Aug 23, 2023
d492018
update CSSProperties to import from react
Jod929 Aug 24, 2023
6a74d5c
add release notes for MobileTable
Jod929 Aug 24, 2023
b0a5edb
:bug: Schedule editor: Linked transactions table collapses (#1571)
trevdor Aug 24, 2023
2cc32f6
delete unneeded release note file
Jod929 Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions ...ient/src/components/budget/MobileTable.js → ...ent/src/components/budget/MobileTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,18 @@
import React from 'react';
import React, { type ReactNode } from 'react';

import { type CSSProperties } from 'glamor';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @joel-jeremy

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use React's CSSProperties here instead of glamor's

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the input, I'll fix that.


import { colors } from '../../style';
import View from '../common/View';

export const ROW_HEIGHT = 50;

export const ListItem = ({ children, style, ...props }) => {
type ListItemProps = {
children?: ReactNode;
style: CSSProperties;
};

export const ListItem = ({ children, style, ...props }: ListItemProps) => {
return (
<View
style={[
Expand Down
6 changes: 6 additions & 0 deletions upcoming-release-notes/1578.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
category: Maintenance
authors: [Jod929]
---

Refactor MobileTable to tsx.