Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MobileTable tsx Refactor #1578

Closed
wants to merge 10 commits into from
Closed

MobileTable tsx Refactor #1578

wants to merge 10 commits into from

Conversation

Jod929
Copy link
Contributor

@Jod929 Jod929 commented Aug 23, 2023

Refactor MonthCountSelector to TSX related to issue #1483

@netlify
Copy link

netlify bot commented Aug 23, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 2cc32f6
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/64e7b34de48b5a0008ac490d
😎 Deploy Preview https://deploy-preview-1578.demo.actualbudget.org/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Jod929 Jod929 closed this Aug 23, 2023
@Jod929 Jod929 deleted the Jod929-ts-refactor branch August 23, 2023 18:55
@Jod929 Jod929 restored the Jod929-ts-refactor branch August 23, 2023 18:56
@Jod929 Jod929 reopened this Aug 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2023

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
14 2.13 MB 0%
Changeset
File Δ Size
src/components/budget/MobileTable.tsx 🆕 +444 B 0 B → 444 B
src/components/budget/MobileTable.js 🔥 -444 B (-100%) 444 B → 0 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/main.js 967.75 kB 0%
static/js/171.chunk.js 396.24 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/wide-components.chunk.js 137.18 kB 0%
static/js/383.chunk.js 117.35 kB 0%
static/js/reports.chunk.js 40.59 kB 0%
static/js/narrow-components.chunk.js 25.19 kB 0%
static/js/969.chunk.js 12.94 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.12 kB 0%
static/css/main.css 5.82 kB 0%
asset-manifest.json 1.78 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 963 B 0%

@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2023

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 1.97 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1013.48 kB 0%
xfo.xfo.kcab.worker.js 1004.04 kB 0%

import React from 'react';
import React, { type ReactNode } from 'react';

import { type CSSProperties } from 'glamor';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use React's CSSProperties here instead of glamor's

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the input, I'll fix that.

@Jod929 Jod929 closed this Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants