Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for alignment should be added #184

Open
stephenswat opened this issue Jun 28, 2022 · 1 comment
Open

Tests for alignment should be added #184

stephenswat opened this issue Jun 28, 2022 · 1 comment
Labels
tests This issue or pull request is related to the test suite

Comments

@stephenswat
Copy link
Member

Also following #181, we need to add new tests to ensure that the alignment requirements are actually met. Preferably after #183 is completed.

@stephenswat stephenswat added the tests This issue or pull request is related to the test suite label Jun 28, 2022
@krasznaa
Copy link
Member

krasznaa commented Mar 4, 2024

Was done a while ago with:

Though we may want to still do a little bit more for the "device resources". 🤔 With those only the SYCL memory resources align their allocations explicitly. With CUDA and HIP we get a 0x400 alignment on all allocations, which tends to be enough in real life. Though would fail the alignment tests shown above. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests This issue or pull request is related to the test suite
Projects
None yet
Development

No branches or pull requests

2 participants