Merge pull request #36 from jc00ke/limit-number-links-in-desceiption

Limit the # of links allowed in event description

Author: reidab

app/controllers/events_controller.rb

@@ -74,8 +74,12 @@ def create
       flash[:failure] = "<h3>Evil Robot</h3> We didn't create this event because we think you're an evil robot. If you're really not an evil robot, look at the form instructions more carefully. If this doesn't work please file a bug report and let us know."
     end
 
+    if too_many_links = too_many_links?(@event.description)
+      flash[:failure] = "We allow a maximum of 3 links in a description. You have too many links."
+    end
+
     respond_to do |format|
-      if !evil_robot && params[:preview].nil? && @event.save
+      if !evil_robot && !too_many_links && params[:preview].nil? && @event.save
         flash[:success] = 'Your event was successfully created. '
         format.html {
           if has_new_venue && !params[:venue_name].blank?
@@ -108,8 +112,12 @@ def update
       flash[:failure] = "<h3>Evil Robot</h3> We didn't update this event because we think you're an evil robot. If you're really not an evil robot, look at the form instructions more carefully. If this doesn't work please file a bug report and let us know."
     end
 
+    if too_many_links = too_many_links?(@event.description)
+      flash[:failure] = "We allow a maximum of 3 links in a description. You have too many links."
+    end
+
     respond_to do |format|
-      if !evil_robot && params[:preview].nil? && @event.update_attributes(params[:event])
+      if !evil_robot && !too_many_links && params[:preview].nil? && @event.update_attributes(params[:event])
         flash[:success] = 'Event was successfully updated.'
         format.html {
           if has_new_venue && !params[:venue_name].blank?
@@ -219,6 +227,12 @@ def clone
 
 protected
 
+  # Checks if the description has too many links
+  # which is probably spam
+  def too_many_links?(description)
+    description.scan(/http/).size > 3
+  end
+
   # Export +events+ to an iCalendar file.
   def ical_export(events=nil)
     events = events || Event.future.non_duplicates

spec/controllers/events_controller_spec.rb

@@ -419,6 +419,18 @@
         flash[:failure].should match /evil robot/i
       end
 
+      it "should not allow too many links in the description" do
+        @params[:event][:description] = <<-DESC
+          http://example.com
+          https://example.com
+          http://example.net
+          https://example.net
+        DESC
+        post "create", @params
+        response.should render_template :new
+        flash[:failure].should match /too many links/i
+      end
+
       it "should allow the user to preview the event" do
         event = Event.new(:title => "Awesomeness")
         Event.should_receive(:new).and_return(event)
@@ -555,6 +567,18 @@
         flash[:failure].should match /evil robot/i
       end
 
+      it "should not allow too many links in the description" do
+        @params[:event][:description] = <<-DESC
+          http://example.com
+          https://example.com
+          http://example.net
+          https://example.net
+        DESC
+        post "create", @params
+        response.should render_template :new
+        flash[:failure].should match /too many links/i
+      end
+
       it "should allow the user to preview the event" do
         tags = []
         tags.should_receive(:reload)