Skip to content

Commit 3f22535

Browse files
Yucong Sunanakryiko
authored andcommitted
Fix text grouping issue on github actions
github action grouping is broken because we were outputing "::endgroup" where it needs "::endgroup::". This patch also added some addtional grouping around contianer setup phase, making output easier to read.
1 parent f8ab8bd commit 3f22535

File tree

4 files changed

+6
-4
lines changed

4 files changed

+6
-4
lines changed

.github/actions/setup/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,6 @@ runs:
1818
echo export REPO_ROOT=$GITHUB_WORKSPACE >> /tmp/ci_setup
1919
echo export CI_ROOT=$REPO_ROOT/travis-ci >> /tmp/ci_setup
2020
echo export VMTEST_ROOT=$CI_ROOT/vmtest >> /tmp/ci_setup
21-
echo 'echo ::endgroup' >> /tmp/ci_setup
21+
echo 'echo ::endgroup::' >> /tmp/ci_setup
2222
shell: bash
2323

.github/workflows/coverity.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
export COVERITY_SCAN_NOTIFICATION_EMAIL="${AUTHOR_EMAIL}"
2020
export COVERITY_SCAN_BRANCH_PATTERN=${GITHUB_REF##refs/*/}
2121
export TRAVIS_BRANCH=${COVERITY_SCAN_BRANCH_PATTERN}
22-
echo ::endgroup
22+
echo ::endgroup::
2323
scripts/coverity.sh
2424
env:
2525
COVERITY_SCAN_TOKEN: ${{ secrets.COVERITY_SCAN_TOKEN }}

travis-ci/managers/debian.sh

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,12 +38,14 @@ for phase in "${PHASES[@]}"; do
3838
$DOCKER_RUN -v $REPO_ROOT:/build:rw \
3939
-w /build --privileged=true --name $CONT_NAME \
4040
-dit --net=host debian:$DEBIAN_RELEASE /bin/bash
41+
echo -e "::group::Build Env Setup"
4142
docker_exec bash -c "echo deb-src http://deb.debian.org/debian $DEBIAN_RELEASE main >>/etc/apt/sources.list"
4243
docker_exec apt-get -y update
4344
docker_exec apt-get -y install aptitude
4445
docker_exec aptitude -y build-dep libelf-dev
4546
docker_exec aptitude -y install libelf-dev
4647
docker_exec aptitude -y install "${ADDITIONAL_DEPS[@]}"
48+
echo -e "::endgroup::"
4749
;;
4850
RUN|RUN_CLANG|RUN_GCC10|RUN_ASAN|RUN_CLANG_ASAN|RUN_GCC10_ASAN)
4951
if [[ "$phase" = *"CLANG"* ]]; then
@@ -62,7 +64,7 @@ for phase in "${PHASES[@]}"; do
6264
docker_exec mkdir build install
6365
docker_exec ${CC:-cc} --version
6466
info "build"
65-
docker_exec make -j$((4*$(nproc))) CFLAGS="${CFLAGS}" -C ./src -B OBJDIR=../build
67+
docker_exec make -j$((4*$(nproc))) CFLAGS="${CFLAGS}" -C ./src -B OBJDIR=../build
6668
info "ldd build/libbpf.so:"
6769
docker_exec ldd build/libbpf.so
6870
if ! docker_exec ldd build/libbpf.so | grep -q libelf; then

travis-ci/vmtest/helpers.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ travis_fold() {
1717
line="$line - ${YELLOW}$3${NOCOLOR}"
1818
fi
1919
else
20-
line="::endgroup"
20+
line="::endgroup::"
2121
fi
2222
echo -e "$line"
2323
fi

0 commit comments

Comments
 (0)