Samples# dramatically decreases if preciseIP is non-zero. #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

pengfei-su opened this issue Jul 22, 2019 · 1 comment

pengfei-su commented Jul 22, 2019

Line 1142 in 6861f4b

false, false, // 2 bits for skid constraint

In the sampling mode, I found the number of samples is dramatically reduced if preciseIP =1,2,3 instead of 0. Did I miss sth important?

Contributor

pwaller commented May 10, 2020

Missing samples can generally be explained by #23 -- for which there is a fix in #26. Please can you test #26 and report back?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment