-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider using SVG for default favicon #398
Comments
we should choose a random emoji https://twitter.com/LeaVerou/status/1241619866475474946 |
maybe our approach for predefining a range of icons in the template needs to be further thought about should the template be defining icons or icons that 404? should we insist on a favicon.ico at root for various tools? (strava apparently does this) we should probably not supply default generic icons as the various defaults when things are missing are better than explicitly defining something wrong |
maybe we should have comments with todos for here is where your icon goes |
Do browsers still cache old icons for ages? I think our advice should include making sure that your icon has a fingerprint in the filename and not to rely on default Overall I am not in favour of us adding a default favicon. I am in favour of us maybe adding a helpful comment near where they would add it. |
Modern browsers now support using SVGs for favicons - should we have a stock favicon which uses https://www.rubydoc.info/github/rails/webpacker/Webpacker/Helper:favicon_pack_tag in the generated template to encourage projects down this path and make it easy?
The text was updated successfully, but these errors were encountered: