Handle JSON errors more gracefully, add output log

Author: achhabra2

bgl/bgl.go

@@ -268,7 +268,7 @@ func (b *BGLData) HandleMatchResultUpload(result ResultSubmission) (int, error)
 		return 0, err
 	}
 
-	if res.StatusCode != 201 {
+	if res.StatusCode != 200 {
 		log.Println("Submission Error Code", res.StatusCode)
 		return 0, errors.New(string(body))
 	}

main.go

@@ -1,15 +1,20 @@
 package main
 
 import (
+	"fmt"
+	"log"
+	"os"
+
 	"fyne.io/fyne/v2"
 	"fyne.io/fyne/v2/app"
+	"fyne.io/fyne/v2/dialog"
 	"github.com/achhabra2/kqb-json-viewer/icons"
 	"github.com/achhabra2/kqb-json-viewer/stats"
 )
 
 func main() {
-	names := stats.ListStatFiles()
-	data := stats.ReadJson(names[0])
+	setupLogs()
+
 	mainIcon := fyne.NewStaticResource("logo.png", icons.Logo)
 
 	a := app.NewWithID("com.kqb-json-viewer.app")
@@ -19,13 +24,33 @@ func main() {
 
 	w := a.NewWindow("KQB JSON Viewer")
 
-	kqbApp := KQBApp{
-		files:        names,
-		selectedData: data,
-		a:            a,
-		w:            w,
+	names := stats.ListStatFiles()
+	data, err := stats.ReadJson(names[0])
+	if err != nil {
+		dialog := dialog.NewError(err, w)
+		dialog.SetOnClosed(func() { os.Exit(1) })
+		dialog.Show()
+		w.Resize(fyne.NewSize(500, 900))
+		w.CenterOnScreen()
+		w.ShowAndRun()
+	} else {
+		kqbApp := KQBApp{
+			files:        names,
+			selectedData: data,
+			a:            a,
+			w:            w,
+		}
+
+		kqbApp.ShowMainWindow()
 	}
 
-	kqbApp.ShowMainWindow()
+}
+
+func setupLogs() {
+	f, err := os.OpenFile("./kqb-json-viewer-output.log", os.O_APPEND|os.O_CREATE|os.O_RDWR, 0666)
+	if err != nil {
+		fmt.Printf("error opening file: %v", err)
+	}
 
+	log.SetOutput(f)
 }

stats/graphs_test.go

@@ -7,7 +7,7 @@ import (
 )
 
 func TestGraph(t *testing.T) {
-	data := ReadJson("../fixtures/sample.json")
+	data, _ := ReadJson("../fixtures/sample.json")
 	img := PlotStats(data)
 
 	// // Save the image.

stats/stats.go

@@ -60,18 +60,23 @@ func sortFiles(files []os.FileInfo) []os.FileInfo {
 	return files
 }
 
-func ReadJson(file string) StatsJSON {
+func ReadJson(file string) (StatsJSON, error) {
 	var statsJSON StatsJSON
 	data, err := ioutil.ReadFile(file)
+	_, fileName := filepath.Split(file)
 	if err != nil {
-		log.Fatal("Could not read json file", err)
+		jsonError := fmt.Errorf("could not read json file\n (%v): %v", fileName, err)
+		log.Println(jsonError.Error())
+		return statsJSON, jsonError
 	}
 	err = json.Unmarshal(data, &statsJSON)
 	if err != nil {
-		log.Fatal("Could not parse json file", err)
+		marshalError := fmt.Errorf("could not properly decode json file\n (%v): %v", fileName, err)
+		log.Println(marshalError.Error())
+		return statsJSON, marshalError
 	}
 
-	return statsJSON
+	return statsJSON, nil
 }
 
 func OpenStatDirectory() {

stats/stats_test.go

@@ -17,7 +17,7 @@ func TestListStats(t *testing.T) {
 
 func TestAdvancedStats(t *testing.T) {
 	names := ListStatFiles()
-	data := ReadJson(names[0])
+	data, _ := ReadJson(names[0])
 	output := data.AdvancedStats()
 	t.Log(output)
 }

ui.go

@@ -90,7 +90,7 @@ func (k *KQBApp) ShowMainWindow() {
 
 	combo := widget.NewSelect(trimmed, func(value string) {
 		log.Println("Select file", value)
-		k.selectedData = stats.ReadJson(trimmedMap[value])
+		k.LoadStatsFile(trimmedMap[value])
 		k.selectedFile = value
 		if k.u.BGLToken != "" {
 			k.u.data = k.selectedData
@@ -111,7 +111,7 @@ func (k *KQBApp) ShowMainWindow() {
 	k.fileDropDown = combo
 
 	advancedStatsButton := widget.NewButtonWithIcon("Adv. Stats", theme.FileImageIcon(), func() {
-		k.selectedData = stats.ReadJson(trimmedMap[combo.Selected])
+		k.LoadStatsFile(trimmedMap[combo.Selected])
 		k.ShowAdvancedStats()
 	})
 
@@ -476,6 +476,16 @@ func (k *KQBApp) ResetUploader() {
 	k.w.Resize(fyne.NewSize(500, 900))
 }
 
+func (k *KQBApp) LoadStatsFile(file string) {
+	newData, err := stats.ReadJson(file)
+	if err != nil {
+		dialog := dialog.NewError(err, k.w)
+		dialog.Show()
+		return
+	}
+	k.selectedData = newData
+}
+
 func getTimeString(file string) string {
 	fInfo, _ := os.Open(file)
 	info, _ := fInfo.Stat()