Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

not optimal loop #136

Open
richbar88 opened this issue Aug 17, 2018 · 0 comments
Open

not optimal loop #136

richbar88 opened this issue Aug 17, 2018 · 0 comments
Labels
code review This issue originated from a code review

Comments

@richbar88
Copy link
Collaborator

https://github.com/mmuellerstoffels/GBSTools/blob/7a20352a8b83e60f675273a79e43e3bfa5dd3385/GBSTool/GBSModel/Generator.py#L73-L74
This loop is not optimal.
Suggestion: Use for example “for fuelCurvePPuInpt_, fuelCurveMFInpt_ in zip(fuelCurvePPuInpt,
fuelCurveMFInpt)”. Than instead of fuelCurvePPuInpt[idx] use fuelCurvePPuInpt_.
@richbar88 richbar88 added the code review This issue originated from a code review label Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code review This issue originated from a code review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@richbar88