Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path not a File 1 #129

Open
richbar88 opened this issue Aug 17, 2018 · 0 comments
Open

Path not a File 1 #129

richbar88 opened this issue Aug 17, 2018 · 0 comments
Labels
code review This issue originated from a code review

Comments

@richbar88
Copy link
Collaborator

https://github.com/mmuellerstoffels/GBSTools/blob/7a20352a8b83e60f675273a79e43e3bfa5dd3385/GBSTool/GBSModel/generateRuns.py#L62
“SetupFile” is a path and not a file. The same happens in line 96 with the variable “compFile”.
Suggestion: Differentiate Files from FilePath in the variable’s name. In line 62 “setupFile” could be
called “setupFilePath” for better understanding. The same could be done for “compFile”.

@richbar88 richbar88 added the code review This issue originated from a code review label Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code review This issue originated from a code review
Projects
None yet
Development

No branches or pull requests

1 participant