fix(common) handles empty headings in markdown translation

Signed-off-by: Jerome Simeon <[email protected]>

Author: jeromesimeon

packages/markdown-common/src/ToMarkdownStringVisitor.js

@@ -197,17 +197,18 @@ class ToMarkdownStringVisitor {
             break;
         case 'Heading': {
             const level = parseInt(thing.level);
-            if (level < 3) {
+            const headingText = ToMarkdownStringVisitor.visitChildren(this, thing, parameters);
+            if (level < 3 && headingText !== '') {
                 parameters.result += ToMarkdownStringVisitor.mkPrefix(parameters,2);
-                parameters.result += ToMarkdownStringVisitor.visitChildren(this, thing, parameters);
+                parameters.result += headingText;
                 parameters.first = false;
                 parameters.result += ToMarkdownStringVisitor.mkPrefix(parameters,1);
                 parameters.result += ToMarkdownStringVisitor.mkSetextHeading(level);
             } else {
                 parameters.result += ToMarkdownStringVisitor.mkPrefix(parameters,2);
                 parameters.result += ToMarkdownStringVisitor.mkATXHeading(level);
                 parameters.result += ' ';
-                parameters.result += ToMarkdownStringVisitor.visitChildren(this, thing, parameters);
+                parameters.result += headingText;
             }
         }
             break;

packages/markdown-common/src/__snapshots__/CommonMarkTransformer.test.js.snap

@@ -1255,6 +1255,43 @@ Object {
 }
 `;
 
+exports[`markdown converts heading-empty.md to concerto JSON 1`] = `
+Object {
+  "$class": "org.accordproject.commonmark.Document",
+  "nodes": Array [
+    Object {
+      "$class": "org.accordproject.commonmark.Heading",
+      "level": "1",
+    },
+    Object {
+      "$class": "org.accordproject.commonmark.Heading",
+      "level": "2",
+    },
+    Object {
+      "$class": "org.accordproject.commonmark.Heading",
+      "level": "1",
+      "nodes": Array [
+        Object {
+          "$class": "org.accordproject.commonmark.Text",
+          "text": "x",
+        },
+      ],
+    },
+    Object {
+      "$class": "org.accordproject.commonmark.Heading",
+      "level": "2",
+      "nodes": Array [
+        Object {
+          "$class": "org.accordproject.commonmark.Text",
+          "text": "x",
+        },
+      ],
+    },
+  ],
+  "xmlns": "http://commonmark.org/xml/1.0",
+}
+`;
+
 exports[`markdown converts headingdigit.md to concerto JSON 1`] = `
 Object {
   "$class": "org.accordproject.commonmark.Document",
@@ -22720,6 +22757,12 @@ exports[`to plain text h5.md 1`] = `"Heading Five"`;
 
 exports[`to plain text h6.md 1`] = `"Heading Six"`;
 
+exports[`to plain text heading-empty.md 1`] = `
+"x
+
+x"
+`;
+
 exports[`to plain text headingdigit.md 1`] = `
 "1\\\\. This is a heading with a digit
 

packages/markdown-common/src/removeFormatting.js

@@ -39,9 +39,11 @@ function mapObject(obj, stack) {
             $class: 'org.accordproject.commonmark.Paragraph',
             nodes: []
         });
-        obj.nodes.forEach(element => {
-            mapObject(element, stack);
-        });
+        if (obj.nodes) {
+            obj.nodes.forEach(element => {
+                mapObject(element, stack);
+            });
+        }
         stack.pop();
         break;
     // wrap in a para and grab text

packages/markdown-common/test/data/heading-empty.md

@@ -0,0 +1,7 @@
+#
+
+##
+
+#   x
+
+##    x