Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not work for China region #49

Closed
liangruibupt opened this issue Aug 14, 2019 · 4 comments
Closed

Can not work for China region #49

liangruibupt opened this issue Aug 14, 2019 · 4 comments

Comments

@liangruibupt
Copy link

aws-es-proxy-0.8-linux-amd64 -endpoint https://search-real-time-bushfire-hql7siqa3m4sz6altvkp3t76e4.cn-north-1.es.amazonaws.com.cn

2019/08/14 05:50:24 error: submitted endpoint is not a valid Amazon ElasticSearch Endpoint

The code

if len(parts) == 5 {
			p.region, p.service = parts[1], parts[2]
		} else {
			return fmt.Errorf("error: submitted endpoint is not a valid Amazon ElasticSearch Endpoint")
		}

should adopt the China region url

*.cn-north-1.es.amazonaws.com.cn
*.cn-northwest-1.es.amazonaws.com.cn

@liangruibupt
Copy link
Author

I can quickly workaround by

if (len(parts) == 5 || len(parts) == 6) {
            p.region, p.service = parts[1], parts[2]
        } else {
            return fmt.Errorf("error: submitted endpoint is not a valid Amazon ElasticSearch Endpoint")
        }

But I cannot build due to issue #50

@abutaha can you help on the support China Region?

@abutaha
Copy link
Owner

abutaha commented Aug 19, 2019

Hi,

thanks for bringing this on. Will have it updated with a new release I'm preparing.

@jerry123je
Copy link

Hi,

any update on this issue?

@abutaha
Copy link
Owner

abutaha commented Apr 5, 2020

Fixed.

@abutaha abutaha closed this as completed Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants