Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter to manage puppetmaster service status #171

Open
wants to merge 4 commits into
base: production
Choose a base branch
from

Conversation

jordigg
Copy link
Contributor

@jordigg jordigg commented May 4, 2018

Add parameter to manage puppetmaster service status. This way the module can manage if puppetserver should be running or not.
By default will be running but it can be stopped if needed, for example when used on a docker instance.

@jordigg
Copy link
Contributor Author

jordigg commented May 4, 2018

@rendhalver when do you think a new release is going to be done? This would help/unblock us big time.

@rendhalver
Copy link
Member

rendhalver commented May 4, 2018

Sounds like a useful addition.
Give me a bit to review and I will see what I can do about pushing out a new release.
Have you tested this in your environment?

@jordigg
Copy link
Contributor Author

jordigg commented May 4, 2018

Thanks a lot, I've got a workaround working by installing dependencies manually and then installing the module from a .tar.gz so no rush on the release if not needed.
I'm using the module on a docker puppetserver to let puppet set itself up rather than hardcode all the setting on the dockerfile/bootstrap-scripts.

@rendhalver
Copy link
Member

I am going to keep this open till I can make that new release.
Please remind me if I haven't gotten to it in a day or so.

@jordigg
Copy link
Contributor Author

jordigg commented May 21, 2018

@rendhalver Sorry to bother, are you going to make a release soon? I want to check and try and get hiera5 support as well in this module.

@rendhalver
Copy link
Member

Thanks for the reminder.
I will get that done soon.
It works pretty well with hiera5 already.

@@ -29,8 +30,8 @@
}

service { 'puppetserver':
ensure => 'running',
enable => true,
ensure => $service_enable,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will setting this to true work with all versions?
Some may not like it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants