Hiera lookups with no default in params.pp

[jantman]

There are 4 hiera() lookups in the first few lines of icinga::params that have no default value. The README says that this module works with an ENC, but at least with these hiera() lookups without default values, it does not. It just dies with a compile error.

[rendhalver]

Thanks for letting me know.
Which variables is it complaining about?

[rendhalver]

Oh and which version are you using? The puppet forge version or the head of the github tree?

[jantman]

I'm using master - at the moment, I'm actually running off of a branch in my fork (https://github.com/jantman/puppet-icinga/tree/enc) since I need to use an ENC with it.

Looks like you already found the variables in question:
jantman@4511749

[rendhalver]

Just wanted to let you know a fix is in progress.
Will update this ticket when it has been committed.

[jantman]

Cool, thanks. I'm currently working off of a fork, but once this fix is done I'll give a try at reconciling them and submitting a pull request if interested. The main thing that I did, other than making it more ENC-friendly, was updating to use the latest version of dependencies, and converting most of the classic GUI stuff to the apache::vhost type.

[rendhalver]

I am currently doing that myself actually...
I have also released new more independent versions of my other modules where possible.

Have you pushed your workings up to github yet?

[rendhalver]

I pushed out rc2 for 1.2.2 today.
I think this will fix the issue.
Do you have time to check if it resolves it?

[jantman]

Unfortunately, I doubt it. After this long, reconciling my fork with this probably won't be simple. I'm still running off of https://github.com/jantman/puppet-icinga/tree/enc ; it has some relatively large changes (https://github.com/jantman/puppet-icinga/compare/enc) and unfortunately we've been through a reorg at work, and I'm not sure whether monitoring is really even in my new group's purview anymore, so I don't think I'll be able to dedicate much work time to this...

[rendhalver]

All cool dude.
I haven't used this one much lately either.
I might have a look at your changes. They might be useful additions to my module.

Will let you know.