Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable commented out that are used in the code #1

Open
impaktor opened this issue Aug 5, 2018 · 6 comments
Open

Variable commented out that are used in the code #1

impaktor opened this issue Aug 5, 2018 · 6 comments

Comments

@impaktor
Copy link

impaktor commented Aug 5, 2018

This block:

;; Settings for column-style == :fixed
;; The defaults roughly match Maltron settings
;;   http://patentimages.storage.googleapis.com/EP0219944A2/imgf0002.png
;; Fixed-z overrides the z portion of the column ofsets above.
;; NOTE: THIS DOESN'T WORK QUITE LIKE I'D HOPED.
(def fixed-angles [(deg2rad 10) (deg2rad 10) 0 0 0 (deg2rad -15) (deg2rad -15)])
(def fixed-x [-41.5 -22.5 0 20.3 41.4 65.5 89.6])  ; relative to the middle finger
(def fixed-z [12.1    8.3 0  5   10.7 14.5 17.5])
(def fixed-tenting (deg2rad 0))

...is commented out in master, and have been since commit a4014a2. Without it, the code will not run to generate *.scad files.

@irrenhaus
Copy link

irrenhaus commented Aug 14, 2018

Can confirm this @abstracthat.

Just cloned the project and wanted to build it but it turned out that the compiler gave an error.
Luckily this issue was opened, so I was able to resolve it by uncommenting these variables.

Edit: Actually, after looking at the generated OpenSCAD code, it's still broken afterwards. The model is rotated by an insane angle and cut off in the middle.

@impaktor
Copy link
Author

impaktor commented Aug 14, 2018

@irrenhaus I would recommend cloning (or forking) the original dactyl manuform mod instead, which is by @tshort, here

If you check the commit history, @adereth did the original, @tshort did the Dactyl Manuform, but as a branch of his fork, and this repo just renamed the project to the same name as tshort's branch. Quite confusing. Or at least that's how I interpret it.

The top post of geekhack links to the correct site, i.e. tshort's repo, I'm not sure how I ended up here.

(I'll be doing a PLA 3D print of this tomorrow, so we'll see how it turns out.)

EDIT: fast correction to geekhack statement.

@irrenhaus
Copy link

@impaktor Oh thanks a bunch! I think I got to this repository through google, so maybe it's just ranked up higher than the correct repository there.

@impaktor
Copy link
Author

@irrenhaus no problem. I've opened a pull request on tshorts repo, also saving out the swich hole for test printing. It looks to me like what this repo (abstracthat) went for was a 90 degree vertical stagger.

@abstracthat
Copy link
Owner

Hi guys. Didn't mean to deceive anyone this is indeed just a fork.

And I haven't printed it but would like to. I don't remember breaking the compile though as I had open scad running while l was tweaking. But it's certainly possible!

It is a very large tenting angle (I use a split Mitosis keyboard on 55degree wood blocks at the moment which I like a lot). I also messed with where the thumb keys sit and I started to move the screws for the bottom plate because they don't line up quite right when the footprint is changed so much for the large tenting.

@impaktor
Copy link
Author

Hi guys. Didn't mean to deceive anyone this is indeed just a fork.

Yeah, sorry, I didn't mean to come off like I'm implying that.

It is a very large tenting angle

I wonder if a hollow keyboard has enough friction to the surface to be used at 90-degree angle?

Some of the tweeks I'm aiming to implement on my fork is to re-import the original TRRS jack, instead of the RJ9 connector. I'm currently just where I need to figure out how to move the TRRS hole to where I want it.

Also, Alps/Matias switch holes would be nice, which is also something I'll play around with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants