-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider using service healthcheck in Dockerfile #1543
Comments
The only problem I see is that we need an external HTTP client to use our HTTP API health check endpoint (like in this example) and we are using |
What I found interesting is that official docker images on docker hub do NOT have healtcheks. Also, healthchecks can be implemented in docker-compose, instead of in docker images, so given these reasons it may be better to use it there instead of |
These reasons sound sane to me. That is, we leave health checking to the user, and provide an endpoint that can be used for that. If @mainflux/maintainers agree, I will close this one. |
Closing this one due to reasons @blokovi explained in the comment. |
ENHANCEMENT
We should consider using internal health check endpoints for exposing in Dockerfile like it's mentioned here.
This is a should-have enhancemenet.
The text was updated successfully, but these errors were encountered: