Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

users.info does not include roles #20

Open
andreas-it-dev opened this issue Feb 17, 2018 · 4 comments
Open

users.info does not include roles #20

andreas-it-dev opened this issue Feb 17, 2018 · 4 comments

Comments

@andreas-it-dev
Copy link

Hi,

even though the api docs suggest it should ( https://rocket.chat/docs/developer-guides/rest-api/users/info/ ),calling users.info with an admin user only includes the bare minimums:

@session.users.info(username: @user.username)
=> #<RocketChat::User:0x70137576055220 @id="NJLPbJWM3nRk2M8zY" @username="Andreas" @Active="true">

any hint what i might do wrong?

thanks,
Andreas

@abrom
Copy link
Owner

abrom commented Feb 17, 2018

Hi @awunder,

There may be a couple of things to consider here. The User model will only display some specific fields if you just dump it out on the console. There may also be some permission issues with your RocketChat user.

What do you get if you try view the raw data?

I.e.

@session.users.info(username: @user.username).data

@andreas-it-dev
Copy link
Author

Hey @abrom ,

wow, that was quick :)

i did a further look, forked your gem and played around a bit..

looks like it wasnt implemented on "your side" so i followed your style and fiddled it in...

i never made a pull req in my life so i am a bit lost.. however, this is what i've changed:

andreas-it-dev@10f3f13#diff-c92145718ff59c223c017f5efe02475e

am probably implementing some other stuff as well while i'm going along the path of integrating rocket chat to my webapp...

so, maybe i'll figure out the pull req thing on that route as well..

thanks for your great gem,
Andreas

@abrom
Copy link
Owner

abrom commented Feb 17, 2018

I've left some comments for you. I'd ask that you include a test for your change though

Creating a PR is pretty easy. Take a look at the Github documentation:
https://help.github.com/articles/creating-a-pull-request-from-a-fork/

@abrom
Copy link
Owner

abrom commented Feb 17, 2018

And in the mean time, you should be able to get what you need with:

@session.users.info(username: @user.username).data['roles']

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants