Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Needs to work with multiple ships #4

Open
abrindam opened this issue Jan 10, 2016 · 2 comments
Open

Needs to work with multiple ships #4

abrindam opened this issue Jan 10, 2016 · 2 comments
Labels
bug

Comments

@abrindam
Copy link
Owner

There are several places in the code where we do getPlayerShip(0). This probably will break in a game with multiple ships.
@abrindam abrindam added the bug label Jan 10, 2016
@jacobmaxfrank
Copy link
Collaborator

All playable models are ready as OBJ files. The correct model file needs to be selected based on ship class in Damcon.java:loadAndWireframeifyModel().

abrindam pushed a commit that referenced this issue Oct 3, 2016
WIP #4: Add APIs to mark a client ready and to set the ship the clien…
2dc1215 
…t will be using. Support for changing displayed model based on this still needed.
abrindam pushed a commit that referenced this issue Oct 3, 2016
WIP #4: Expose API to list available ships
775f8c4
jacobmaxfrank added a commit that referenced this issue Oct 3, 2016
@jacobmaxfrank
WIP #4: ShipSelectionPanel
8ddf76a 
-Replace PreGamePanel with ShipSelectionPanel
-Radio button group implementation

Also:
-Fix default ready to false
-Add accessors for Ship
-Catch for null callback
-TransparentJPanel now defaults to null LayoutManager

Various debugging/WIP/hack stuff is left in to help debug this issue:
-Hack in getCurrentShip() defaulting to 1
-Hack in RealEngineeringConsoleManager.java left in but commented
-Need to sleep in selectShip()?
-Print sending ready
-Print sending ship/console selection
@jacobmaxfrank
Copy link
Collaborator

FYI the code as of the above commit does not properly handle receiving an updated list of ship names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jacobmaxfrank @abrindam