Skip to content

Conversation

@ejohnson-dotnet
Copy link
Contributor

The ReverseMap methods will map the destination type back to the source type, but the "source" object will be of type TDestination. In other words, the "TDestination source" object is copied to the "TSource destination" object.

Description

Resolves #24265

This fixes the misleading parameter names to make clear which is the source object and which is the destination object.

This file already has the parameter names correctly implemented.
modules/identityserver/src/Volo.Abp.IdentityServer.Domain/Volo/Abp/IdentityServer/IdentityServerMapperlyMappers.cs

Checklist

  • I fully tested it as developer / designer and created unit / integration tests
  • I documented it (or no need to document or I will create a separate documentation issue)

How to test it?

Please describe how this can be tested by the test engineers if it is not already explicit - or remove this section if no need to description.

The ReverseMap methods will map the destination type back to the source type, but the "source" object will be of type TDestination.   In other words, the "TDestination source" object is copied to the "TSource destination" object.
@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.06%. Comparing base (f759691) to head (1b87bc8).
⚠️ Report is 15 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #24266      +/-   ##
==========================================
- Coverage   51.07%   51.06%   -0.01%     
==========================================
  Files        3288     3288              
  Lines      107052   107061       +9     
  Branches     8221     8223       +2     
==========================================
- Hits        54677    54675       -2     
- Misses      50692    50701       +9     
- Partials     1683     1685       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maliming maliming self-requested a review November 25, 2025 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The ReverseMap parameter names are misleading

1 participant