Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JWT (JSON Web Token) authentication #569

Closed
QuintinWillison opened this issue Dec 6, 2022 · 6 comments · Fixed by #669
Closed

JWT (JSON Web Token) authentication #569

QuintinWillison opened this issue Dec 6, 2022 · 6 comments · Fixed by #669
Assignees
Labels
enhancement New feature or improved functionality.

Comments

@QuintinWillison
Copy link
Contributor

QuintinWillison commented Dec 6, 2022

Lack of support for JWTs is documented under Known Limitations. It's also highlighted in the tests.

Also, the concept of "unimplemented test" was introduced at some point to the backlog. I'm going to close all of these issues as they add no value to the backlog (the work to be done is under this issue) however I am recording them here for reference:

┆Issue is synchronized with this Jira Task by Unito

@sync-by-unito
Copy link

sync-by-unito bot commented Dec 6, 2022

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3139

@SimonWoolf
Copy link
Member

SimonWoolf commented Aug 30, 2024

It looks like the only missing feature here is that the SDK doesn't handle a content-type of application/jwt as a synonym for text/plain. (After all, the SDK handles text tokens opaquely anyway; it doesn't need to anything special for JWT, it passes it on to the server same as with a legacy token string).

This is hardly essential; until that's implemented the customer can just have their auth server return encoded jwts with a content-type of text/plain.

I think listing "JWT authentication using auth-url is not implemented" as a "known limitation" is misleading; customers might be put off using JWTs for no good reason. We should just document the content-type limitation. (Or add support for the extra content-type, surely it's like one line of code)

@lmars
Copy link
Member

lmars commented Aug 30, 2024

Or add support for the extra content-type, surely it's like one line of code

Definitely advocate for that...

case "text/plain":

@sacOO7
Copy link
Collaborator

sacOO7 commented Aug 31, 2024

Link to internal conversation -> https://ably-real-time.slack.com/archives/CURL4U2FP/p1725031482412929

@sacOO7
Copy link
Collaborator

sacOO7 commented Aug 31, 2024

This issue is strongly related to server/client initiated auth.

@sacOO7 sacOO7 mentioned this issue Sep 3, 2024
@sacOO7
Copy link
Collaborator

sacOO7 commented Sep 4, 2024

JWT related conversation using echoserver -> https://ably-real-time.slack.com/archives/CURL4U2FP/p1713355380562679

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improved functionality.
Development

Successfully merging a pull request may close this issue.

4 participants