Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement incremental backoff and jitter #545

Open
deanna-lad opened this issue Jun 9, 2022 · 3 comments
Open

Implement incremental backoff and jitter #545

deanna-lad opened this issue Jun 9, 2022 · 3 comments
Assignees
Labels
enhancement New feature or improved functionality.

Comments

@deanna-lad
Copy link

deanna-lad commented Jun 9, 2022

Please see the example implementation in js here ably/ably-js#997

Incremental backoff and jitter was added to the features spec in ably/docs#1445

To implement this we need to change the retry behaviour for:

  • When the client connection is in the DISCONNECTED state
  • When a RealtimeChannel is in the SUSPENDED state

The new retry behaviour is specified in RTB1 of the features spec.

RTB1a

The backoff coefficient described in RTB1a can be calculated in javascript like so:

function getBackoffCoefficient(n) {
  return Math.min((n + 2) / 3, 2);
}

RTB1b

The jitter coefficient described in RTB1b can be calculated in javascript like so:

function getJitterCoefficient() {
  return 1 - Math.random() * 0.2;
}

RTB1

The overall retry time calculation should look like:

function getRetryTime(initValue, n) {
  return initValue * getBackoffCoefficient(n) * getJitterCoefficient();
}

The following code can be used to test it:

[1, 2, 3, 4, 5].forEach((n) => {
  console.log(getRetryTime(initValue, n));
});

Which, with an initValue of 15 (seconds) should print something like:

13.917470451245713
18.415226855678757
20.444851032898747
26.650729887092275
27.803382948778786

┆Issue is synchronized with this Jira Task by Unito

@deanna-lad deanna-lad added the enhancement New feature or improved functionality. label Jun 9, 2022
@sacOO7
Copy link
Collaborator

sacOO7 commented Jun 14, 2023

Expression to calculate upper and lower bounds for generated values using getRetryTime

upper = min((retryCount + 2) / 3, 2) *initialTimeout
lower = 0.8 * upper

if x is a generated retryTimeout from getRetryTime, then

lower < x < upper

@sacOO7
Copy link
Collaborator

sacOO7 commented Dec 11, 2023

Reference impl
ably/ably-dotnet#1176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improved functionality.
Development

No branches or pull requests

2 participants