From ca265da47900e77d3c03f40e9ccfe566d4833d4c Mon Sep 17 00:00:00 2001 From: Abel Soares Siqueira Date: Mon, 8 Jul 2024 10:23:01 +0200 Subject: [PATCH] Make TestOnPRs part of minimal template The intrusive part of TestOnPRs is the ReusableTest, which is already added in the minimal. So we might as well benefit from it and have the improved PR testing. This removes the question and fix the files accordingly. Closes #312 Breaking change: Question SimplifiedPRTest is removed. If you chose recommended or explicitly answered it as true, nothing changes. If you chose minimum or explicitly answered it as false, you will have a new file .github/workflows/TestOnPRs.yml and your Test.yml will change. Pull Requests will run on a smaller matrix now. See the docs for more information. --- CHANGELOG.md | 7 ++++++- copier.yml | 6 ------ template/.github/workflows/Test.yml.jinja | 8 -------- ...TestOnPRs.yml{% endif %}.jinja => TestOnPRs.yml.jinja} | 0 4 files changed, 6 insertions(+), 15 deletions(-) rename template/.github/workflows/{{% if SimplifiedPRTest %}TestOnPRs.yml{% endif %}.jinja => TestOnPRs.yml.jinja} (100%) diff --git a/CHANGELOG.md b/CHANGELOG.md index 574321e7..f025a6b5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,7 +11,12 @@ and this project adheres to [Semantic Versioning]. ### Changed -- GitHub PR template is now part of the minimal options (#308) +- (breaking change) GitHub PR template is now part of the minimal options (#308) +- (breaking change) TestOnPRs.yml is now part of the minimal options (#312) + +### Removed + +- (breaking change) Question SimplifiedPRTest was removed and the behaviour now is as if it were selected as true (#312) ## [0.7.2] - 2024-07-07 diff --git a/copier.yml b/copier.yml index 0559b984..7d3fc489 100644 --- a/copier.yml +++ b/copier.yml @@ -64,12 +64,6 @@ AddPrecommit: help: Pre-commit (Whether to add pre-commit.org. It runs before every commit fixing your formatting and preventing bad practices) # CI -SimplifiedPRTest: - when: "{{ AnswerStrategy == 'ask' }}" - type: bool - help: Simplified PR Test (Do you want to limit the Pull Request test to a single configuration (ubuntu + latest stable Julia)? This will make the PR tests run faster, but might miss OS-specific or LTS specific errors) - default: "{{ AnswerStrategy != 'minimum' }}" - AddMacToCI: when: "{{ AnswerStrategy == 'ask' }}" type: bool diff --git a/template/.github/workflows/Test.yml.jinja b/template/.github/workflows/Test.yml.jinja index 41a6d71f..6e83089e 100644 --- a/template/.github/workflows/Test.yml.jinja +++ b/template/.github/workflows/Test.yml.jinja @@ -5,14 +5,6 @@ on: branches: - main tags: ["*"] - {% if not SimplifiedPRTest %}pull_request: - branches: - - main - paths: - - "src/**" - - "test/**" - - "*.toml" - types: [opened, synchronize, reopened]{% endif %} workflow_dispatch: jobs: diff --git a/template/.github/workflows/{% if SimplifiedPRTest %}TestOnPRs.yml{% endif %}.jinja b/template/.github/workflows/TestOnPRs.yml.jinja similarity index 100% rename from template/.github/workflows/{% if SimplifiedPRTest %}TestOnPRs.yml{% endif %}.jinja rename to template/.github/workflows/TestOnPRs.yml.jinja