Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git commands to TestGeneratedPkg workflow and fix deving the pkg #323

Closed
wants to merge 1 commit into from

Conversation

abelsiqueira
Copy link
Owner

Documenter looks for the package in the registry unless it is
pkg> dev'ed.
makedocs makes use of git information, so we create a git repo with
a commit and a remote.
Also changes the PackageOwner to someone that does not exist.

Closes #322

@abelsiqueira abelsiqueira requested a review from suvayu July 4, 2024 09:04
Documenter looks for the package in the registry unless it is
pkg> dev'ed.
makedocs makes use of git information, so we create a git repo with
a commit and a remote.
Also changes the PackageOwner to someone that does not exist.

Closes #322
@abelsiqueira abelsiqueira marked this pull request as draft July 4, 2024 09:59
Copy link
Collaborator

@suvayu suvayu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that you rediscovered the reason for the git commit, maybe document it somewhere? Maybe as a comment in Test.yml?

@abelsiqueira
Copy link
Owner Author

Will do, but it looks like this is still failing (I'm debugging here: https://github.com/abelsiqueira/BestieTemplate.jl/actions/runs/9792416120)

@abelsiqueira
Copy link
Owner Author

abelsiqueira commented Jul 7, 2024

Solved in #329, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug] Workflow TestGeneratedPkg is failing
2 participants