Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update headers with "This file was created by BestieTemplate.jl." #305

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lyashevska
Copy link
Collaborator

Related issues

Closes #282

Checklist

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8cb70c2) to head (e0885f7).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #305   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           57        57           
=========================================
  Hits            57        57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -1,49 +1,50 @@
# This file was created by BestieTemplate.jl. Create issues there: https://github.com/abelsiqueira/BestieTemplate.jl/issues
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lyashevska, these files have all lost their indentation, can you fix it, please?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this, will check now. It must be my editor.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed now.

Copy link
Collaborator

@abelsiqueira abelsiqueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as "Request changes" to help organization.

@abelsiqueira
Copy link
Collaborator

Thanks!

@tmigot, can you review this? It's related to the issue #282 that you created.

Copy link
Contributor

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
It feels that some files are missing though. Shouldn't we have the message in every file that is impacted by an update of BestieTemplate?

@abelsiqueira
Copy link
Collaborator

I think it should be in every file that is maintained by Bestie. So the README shouldn't have a message like this.
Do you feel some other file should have it?

@tmigot
Copy link
Contributor

tmigot commented Jul 23, 2024

Ok, so there is a difference between the files generated and the files maintained.
Candidates for having the header in the main folder:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add somewhere that the files have been generated by BestieTemplate
3 participants