-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update headers with "This file was created by BestieTemplate.jl." #305
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #305 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 57 57
=========================================
Hits 57 57 ☔ View full report in Codecov by Sentry. |
@@ -1,49 +1,50 @@ | |||
# This file was created by BestieTemplate.jl. Create issues there: https://github.com/abelsiqueira/BestieTemplate.jl/issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lyashevska, these files have all lost their indentation, can you fix it, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spotting this, will check now. It must be my editor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking as "Request changes" to help organization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
It feels that some files are missing though. Shouldn't we have the message in every file that is impacted by an update of BestieTemplate?
I think it should be in every file that is maintained by Bestie. So the README shouldn't have a message like this. |
Ok, so there is a difference between the files generated and the files maintained.
|
Related issues
Closes #282
Checklist