Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply template to packages and gather feedback #106

Closed
abelsiqueira opened this issue May 17, 2024 · 3 comments
Closed

Apply template to packages and gather feedback #106

abelsiqueira opened this issue May 17, 2024 · 3 comments
Labels
investigation The issue requires investigation to define a closing action (not to be mistaken with needs more info usage docs Related to documentation on how to use the package or template

Comments

@abelsiqueira
Copy link
Owner

Choose a package, apply the template, see the result, gather feedback.

Some possible questions:

  • Report the package usage experience
  • How clear is the documentation?
  • Any errors?
  • How easy to solve are the conflicts?
  • How much does pre-commit run -a changes the existing package structure?
  • How much does the workflows differ
  • How much are we contributing to the package

Warning

Don't create pull request adding the changes to the package without discussing it in an issue with the package owners first.

@abelsiqueira abelsiqueira added usage docs Related to documentation on how to use the package or template investigation The issue requires investigation to define a closing action (not to be mistaken with needs more info labels May 17, 2024
@abelsiqueira abelsiqueira added this to the 0.5.0 - Hack & Feed 1 milestone May 17, 2024
@luisaforozco
Copy link
Collaborator

Hello, I have tried to apply CopierTemplate.jl to one of my projects and I have the following comments:
The use of CopierTemplate.jl was very straightforward.

  • How clear is the documentation?
    It would be nice to have an explicit section at Quickstart dedicated to applying the template to an existing project via:
    copier copy https://github.com/abelsiqueira/COPIERTemplate.jl .
    Currently only working via python.
    It would also be nice to mention explicitly that you can add multiple authors separated by , and the same for emails.
    Documentation improvements to the full guide #147
  • Errors:
    The UUID that it fills out is going to be random, not the one of the project. it would be nice if in the docs there is a be careful! message.
  • How easy to solve are the conflicts?
    I got conflicts and choose to overwrite the files, but only Y/n choice.
 Overwrite docs/make.jl? [Y/n]

It would be nice if you could see the diff, maybe resolve the conflicts like in git?

  • Other notes:
    I had an Apache 2.0 license, I selected the same, and it did not overwrote them. (this is nice behaviour!)

@abelsiqueira
Copy link
Owner Author

Hi @luisaforozco, thanks for the feedback. Here is some follow through:

Thanks!

@abelsiqueira
Copy link
Owner Author

Created TulipaEnergy/TulipaIO.jl#50 and TulipaEnergy/TulipaIO.jl#51, which are part of the NextGenOpt project.

  • How easy to solve are the conflicts?

README.md and docs/src/index.md are mostly lost in the first application or the first change in all contributors.

  • How much does pre-commit run -a changes the existing package structure?

In this case, the Julia codes were using 4 spaces for indentation and most other files were using 2, so it made several changes.

@abelsiqueira abelsiqueira modified the milestones: JuliaCon, 1.0 Jul 4, 2024
@abelsiqueira abelsiqueira removed this from the 1.0 milestone Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
investigation The issue requires investigation to define a closing action (not to be mistaken with needs more info usage docs Related to documentation on how to use the package or template
Projects
Status: Done
Development

No branches or pull requests

2 participants