update (#30)

Author: larshp

cloud/zcl_abapgit_factory.clas.abap

@@ -148,7 +148,7 @@ CLASS ZCL_ABAPGIT_FACTORY IMPLEMENTATION.
   METHOD get_function_module.
 
     IF gi_function_module IS INITIAL.
-      ASSERT 1 = 'decoupled'.
+      CREATE OBJECT gi_function_module TYPE zcl_abapgit_function_module.
     ENDIF.
 
     ri_function_module = gi_function_module.

cloud/zcl_abapgit_function_module.clas.abap

@@ -0,0 +1,42 @@
+CLASS zcl_abapgit_function_module DEFINITION
+  PUBLIC
+  FINAL
+  CREATE PUBLIC .
+
+  PUBLIC SECTION.
+    INTERFACES:
+      zif_abapgit_function_module.
+
+  PROTECTED SECTION.
+  PRIVATE SECTION.
+ENDCLASS.
+
+
+
+CLASS zcl_abapgit_function_module IMPLEMENTATION.
+
+
+  METHOD zif_abapgit_function_module~function_exists.
+
+    DATA lv_function_module_name TYPE c LENGTH 30.
+    DATA lv_exists TYPE string.
+
+    lv_function_module_name = iv_function_module_name.
+    lv_exists = 'FUNCTION_EXISTS'.
+
+    TRY.
+        CALL FUNCTION lv_exists
+          EXPORTING
+            funcname           = lv_function_module_name
+          EXCEPTIONS
+            function_not_exist = 1
+            OTHERS             = 2.
+        rv_exists = boolc( sy-subrc = 0 ).
+      CATCH cx_sy_dyn_call_illegal_func.
+* then its running in ABAP Cloud Programming Model, assume nothing is released
+* I could not find any way to check for this -Hvam
+        rv_exists = abap_false.
+    ENDTRY.
+
+  ENDMETHOD.
+ENDCLASS.

cloud/zcl_abapgit_function_module.clas.xml

@@ -0,0 +1,16 @@
+<?xml version="1.0" encoding="utf-8"?>
+<abapGit version="v1.0.0" serializer="LCL_OBJECT_CLAS" serializer_version="v1.0.0">
+ <asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
+  <asx:values>
+   <VSEOCLASS>
+    <CLSNAME>ZCL_ABAPGIT_FUNCTION_MODULE</CLSNAME>
+    <LANGU>E</LANGU>
+    <DESCRIPT>abapGit - Function Module</DESCRIPT>
+    <STATE>1</STATE>
+    <CLSCCINCL>X</CLSCCINCL>
+    <FIXPT>X</FIXPT>
+    <UNICODE>X</UNICODE>
+   </VSEOCLASS>
+  </asx:values>
+ </asx:abap>
+</abapGit>

cloud/zcl_abapgit_gui_chunk_lib.clas.abap

@@ -849,7 +849,7 @@ CLASS ZCL_ABAPGIT_GUI_CHUNK_LIB IMPLEMENTATION.
       RETURN.
     ENDIF.
 
-    lv_jump = |{ 'decoupled' }?PATH=|.
+    lv_jump = |{ zcl_abapgit_gui_page_repo_view=>c_actions-change_dir }?PATH=|.
 
     ri_html->add( |<span class="path-box">| ).
 

cloud/zcl_abapgit_html.clas.abap

@@ -34,6 +34,9 @@ CLASS zcl_abapgit_html DEFINITION
         iv_str         TYPE string OPTIONAL
       RETURNING
         VALUE(rs_data_attr) TYPE zif_abapgit_html=>ty_data_attr .
+    CLASS-METHODS set_debug_mode
+      IMPORTING
+        iv_mode TYPE abap_bool.
   PROTECTED SECTION.
   PRIVATE SECTION.
 
@@ -105,8 +108,6 @@ CLASS ZCL_ABAPGIT_HTML IMPLEMENTATION.
 
   METHOD class_constructor.
 
-    DATA lv_mode TYPE tabname.
-
     CREATE OBJECT go_single_tags_re
       EXPORTING
         pattern     = '<(AREA|BASE|BR|COL|COMMAND|EMBED|HR|IMG|INPUT|LINK|META|PARAM|SOURCE|!)'
@@ -116,12 +117,13 @@ CLASS ZCL_ABAPGIT_HTML IMPLEMENTATION.
       val = ` `
       occ = c_max_indent ).
 
-    
-    gv_debug_mode = boolc( lv_mode = 'HREF' ).
-
   ENDMETHOD.
 
 
+  METHOD set_debug_mode.
+    gv_debug_mode = iv_mode.
+  ENDMETHOD.
+
   METHOD create.
     CREATE OBJECT ri_instance TYPE zcl_abapgit_html.
     IF iv_initial_chunk IS NOT INITIAL.

cloud/zcl_abapgit_html_action_utils.clas.testclasses.abap

@@ -0,0 +1,22 @@
+CLASS ltcl_test DEFINITION FOR TESTING DURATION SHORT RISK LEVEL HARMLESS FINAL.
+
+  PRIVATE SECTION.
+    METHODS dir_encode FOR TESTING.
+ENDCLASS.
+
+
+CLASS ltcl_test IMPLEMENTATION.
+
+  METHOD dir_encode.
+
+    DATA lv_encoded TYPE string.
+
+    lv_encoded = zcl_abapgit_html_action_utils=>dir_encode( '/hello.,()[]' ).
+
+    cl_abap_unit_assert=>assert_equals(
+      act = lv_encoded
+      exp = 'PATH=%2fhello.%2c()%5b%5d' ).
+
+  ENDMETHOD.
+
+ENDCLASS.

cloud/zcl_abapgit_properties_file.clas.abap

@@ -42,7 +42,7 @@ CLASS zcl_abapgit_properties_file IMPLEMENTATION.
 
 
   METHOD constructor.
-    mv_lang = to_lower( iv_lang ).
+    mv_lang = to_upper( iv_lang ).
   ENDMETHOD.
 
 

cloud/zcl_abapgit_properties_file.clas.testclasses.abap

@@ -0,0 +1,26 @@
+CLASS ltcl_test DEFINITION FINAL FOR TESTING.
+
+  PUBLIC SECTION.
+  PROTECTED SECTION.
+  PRIVATE SECTION.
+    METHODS assert_lang FOR TESTING RAISING cx_static_check.
+
+ENDCLASS.
+
+CLASS ltcl_test IMPLEMENTATION.
+
+  METHOD assert_lang.
+
+    DATA: lo_cut TYPE REF TO zcl_abapgit_properties_file.
+    DATA: lv_act TYPE laiso.
+    CREATE OBJECT lo_cut
+      EXPORTING
+        iv_lang = 'DE'.
+    lv_act = lo_cut->zif_abapgit_i18n_file~lang( ).
+
+    cl_abap_unit_assert=>assert_equals(
+      exp = 'DE'
+      act = lv_act ).
+  ENDMETHOD.
+
+ENDCLASS.

cloud/zcl_abapgit_properties_file.clas.xml

@@ -10,6 +10,7 @@
     <CLSCCINCL>X</CLSCCINCL>
     <FIXPT>X</FIXPT>
     <UNICODE>X</UNICODE>
+    <WITH_UNIT_TESTS>X</WITH_UNIT_TESTS>
    </VSEOCLASS>
   </asx:values>
  </asx:abap>