Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test class ltcl_bobf of class ZCL_ABAPGIT_OBJECT_BY_SOBJ uses /BOBF/CONF_KEY #12

Open
gregorwolf opened this issue Oct 10, 2016 · 4 comments

Comments

@gregorwolf
Copy link
Contributor

Unfortunately the data element /BOBF/CONF_KEY does not exist in a pure SAP NetWeaver ABAP System. It is part of the software component SAP_BS_FND. To allow activation of the abapGit-Plugins without an error I think the data element should be exchanged by another one from SAP_ABA or SAP_BASIS.

larshp added a commit that referenced this issue Oct 11, 2016
@larshp
Copy link
Member

larshp commented Oct 11, 2016

Hi Gregor,
It had more issues than just the one data element, I've temporarily commented some of the code so it activates without problems(tested in 730).

This probably breaks the unit tests, but we can look into fixing those later(please keep this issue open).

@mrsimpson
Copy link
Collaborator

this problem only occurs pre 7.50 ;)

The unittest is quite extensive and indeed can compile only in Systems including BOPF.
What would happen if you moved the actual test into an include (which doesn't compile in older systems) and include the include with IF EXITSTS into the unittest-include?

@larshp
Copy link
Member

larshp commented Oct 11, 2016

having it in a separate include would also cause errors while activating, which would trigger issues to be raised.

Perhaps change the code so the methods are called dynamically, eg. like
CALL METHOD cl_oo_classname_service=>('GET_ALL_CLASS_INCLUDES')

@mrsimpson
Copy link
Collaborator

basically, that meant to move the unittest into a global class and call those methods from the UT dynamically - why not...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants