Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose newly_created on THREAD_CREATE event #1568

Closed
MaSp005 opened this issue Oct 26, 2024 · 1 comment
Closed

Expose newly_created on THREAD_CREATE event #1568

MaSp005 opened this issue Oct 26, 2024 · 1 comment

Comments

@MaSp005
Copy link

MaSp005 commented Oct 26, 2024

The Discord API passes the property newly_created: true on a THREAD_CREATE gateway event. As of 0.18.0, this property is not exposed in the threadCreate event on Eris.Client.

Since the event is fired multiple times for one thread's creation, this property allows the application to distinguish the duplicate emitted events without having to manually track the IDs of created threads.

This could either be implemented by adopting and exposing said property in ThreadChannel#update or by passing it as another argument in the emitted event in Shard.js:2159.

@bsian03
Copy link
Collaborator

bsian03 commented Oct 27, 2024

added to #1464

@bsian03 bsian03 closed this as completed Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants